cvs commit: www/en/cgi Makefile www/share/mk web.site.mk

[Shaun Amott]

On Thu, Jul 21, 2011 at 12:31:30PM +0900, Hiroki Sato wrote:
> Shaun Amott <shaun at FreeBSD.org> wrote
>   in <201107202352.p6KNqCkN034366 at repoman.freebsd.org>:
> 
> sh> shaun       2011-07-20 23:52:12 UTC
> sh>
> sh>   FreeBSD doc repository (ports committer)
> sh>
> sh>   Modified files:
> sh>     en/cgi               Makefile
> sh>     share/mk             web.site.mk
> sh>   Log:
> sh>   Hook up files (Perl modules) for the new query-pr.cgi script. A bit of
> sh>   extra code to handle the fact that the files are in subdirectories was
> sh>   required.
> sh>
> sh>   Revision  Changes    Path
> sh>   1.35      +14 -1     www/en/cgi/Makefile
> sh>   1.77      +9 -1      www/share/mk/web.site.mk
> sh>
> 
>  Thank you for updating the CGI script, but I do not think it is a
>  good idea to add CGI_SUB{DIRS,FILES} into web.site.mk.
>  Sub-directories are handled by bsd.subdir.mk, so it should be used in
>  straightforward way instead of adding new variables/targets.
> 
>  What do you think about the attached patch?  I did not notice these
>  changes were submitted somewhere for review before the commit...
> 
> -- Hiroki

Hi Hiroki,

The change was a temporary quick-fix to get the PR viewer working again.
I am not intimately familiar with the doc build system, so wasn't sure
about the best way to add the new subdirectories; but your way looks a
lot cleaner to me.

The script itself was made available some time ago on freebsd-www, so I
considered it reviewed; I just didn't foresee the need for the other
changes.

Shaun

-- 
Shaun Amott // PGP: 0x6B387A9A
"A foolish consistency is the hobgoblin
of little minds." - Ralph Waldo Emerson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20110721/5eeaa948/attachment.pgp