[Bug 275487] x11-themes/xfce-icons-elementary (still) not prefix-safe

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275487

--- Comment #8 from Guido Falsi <madpilot@FreeBSD.org> ---
(In reply to Mikhail T. from comment #7)

> Why is one better than the other (?)

first of all we are running configure anyway so let's give it the correct
argument. Also, this is clearly how upstream intended things to be done.

Also passing the same information twice goes against multiple generic coding
rules, for example DRY (Don't Repeat Yourself).

IMHO upstream build system could be improved, so well, anything would look a
little hacky here.

The port was clearly wrong before, now that you made me look at it (for a good
reason) I try to produce the best fix possible.


Regarding REINPLACE:

While I could agree that being common practice is not a definitive argument
(but conventions are important), I consider the fact that the porter's handbook
ALWAYS has it silent in the examples is a very strong suggestion.

The reinplace command is usually quite verbose and tends to clog the output.

The handbook does not give a definitive rule except saying that installation
commands should never be silenced.


Anyway I'm going to commit this latest patch shortly, now that we have it
working.

-- 
You are receiving this mail because:
You are the assignee for the bug.