From nobody Sat Dec 02 21:24:25 2023 X-Original-To: xfce@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SjNGx4zwCz52gKl for ; Sat, 2 Dec 2023 21:24:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SjNGx35qTz4lSh for ; Sat, 2 Dec 2023 21:24:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701552265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Av2F0cMb6IBKKMiXhV2/YYbRJP/yyuaMZmrP3mLAmUs=; b=TzAoWpgthRALtsR/8w2ftfyvEGEgtAnsNVy37d22hdS+Kt78uIrQzxghcCOUeznyUlO/aN r9B/6x7s6K80IR+sxhO7oC3flL2sPBHd9iUTy+SIe4xZ2B6+2WInI4pn/Au8pJ+dpP97xz pDMfU6IT8n4zzjheFd2OfTFr6LPHja2jRVK5IHWUloleXMY/dXQukzfwV/Kr8byDEvlUKv M1F4Ml94ECF4yuDyTml+VQ7EfUp0vp7ketu58xlUDeJPvtimRDQQ8kS+Qbn9YL4xSMVCpZ v1NPQeeF62K2ysuQghx6S3zihqCt8swSIFW5hewI7VPUCEt4DkTLdNtiVFnj2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701552265; a=rsa-sha256; cv=none; b=IeNYyCCUQvMdLme0tBNEPMvM9qIzN3PbuYUQgfudZjSxrtF3NjqSqjGfXPfoWRc4jBoPZg ksE1lxKKXTfvVyeDJcLSzAX3LotVSdqaVyRQ6g6gtlFwCTMDnkMEz0gepLFcfYV44+dPgJ qtmtrAYl3OhRwebAEZwFwSeOj1dP3oGsczPRgLVlD1UbKQ+9QIaLQJvNPfNCggD2GGw+hO nbBTUY5vc0Cilb22PMVlWTIwHEoP2U2Vo1C2E0aSWnMryP3Lsyk30G+e5s5MgVj0fayOzH 8c0aQELtFcDAjwdqCIoCFcFterP0YRA0s5rwAMkDNVh1XGqVor9Q/x+IOTrGHA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SjNGx1d7qzYKF for ; Sat, 2 Dec 2023 21:24:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3B2LOP7G043831 for ; Sat, 2 Dec 2023 21:24:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3B2LOPSB043829 for xfce@FreeBSD.org; Sat, 2 Dec 2023 21:24:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 275487] x11-themes/xfce-icons-elementary (still) not prefix-safe Date: Sat, 02 Dec 2023 21:24:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: XFCE List-Archive: https://lists.freebsd.org/archives/freebsd-xfce List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-xfce@freebsd.org X-BeenThere: freebsd-xfce@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275487 --- Comment #8 from Guido Falsi --- (In reply to Mikhail T. from comment #7) > Why is one better than the other (?) first of all we are running configure anyway so let's give it the correct argument. Also, this is clearly how upstream intended things to be done. Also passing the same information twice goes against multiple generic coding rules, for example DRY (Don't Repeat Yourself). IMHO upstream build system could be improved, so well, anything would look a little hacky here. The port was clearly wrong before, now that you made me look at it (for a g= ood reason) I try to produce the best fix possible. Regarding REINPLACE: While I could agree that being common practice is not a definitive argument (but conventions are important), I consider the fact that the porter's hand= book ALWAYS has it silent in the examples is a very strong suggestion. The reinplace command is usually quite verbose and tends to clog the output. The handbook does not give a definitive rule except saying that installation commands should never be silenced. Anyway I'm going to commit this latest patch shortly, now that we have it working. --=20 You are receiving this mail because: You are the assignee for the bug.=