[Bug 273806] x11/libXcursor: Avoid duplicated path in XCURSORPATH

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273806

            Bug ID: 273806
           Summary: x11/libXcursor: Avoid duplicated path in XCURSORPATH
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: x11@FreeBSD.org
          Reporter: madpilot@FreeBSD.org
                CC: x11@FreeBSD.org
            Blocks: 273744
             Flags: maintainer-feedback?(x11@FreeBSD.org)
          Assignee: x11@FreeBSD.org
 Attachment #244858 maintainer-approval?(x11@FreeBSD.org)
             Flags:
             Flags: maintainer-feedback?(x11@FreeBSD.org),
                    merge-quarterly?
                CC: x11@FreeBSD.org

Created attachment 244858
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=244858&action=edit
patch v1

by default libXcursor is being build passing to it an ICONDIR that causes the
configure script to define an XCURSORPATH with that value duplicated. This can
be seen in any build log, the cc commands get this argument:

-DXCURSORPATH=\"~/.local/share/icons:~/.icons:/usr/local/share/icons:/usr/local/share/pixmaps:/usr/local/share/icons\"


This is causing issues with xfce4-mouse-settings from xfce4-settings port,
which scans this path for cursor themes. This software performs no checks for
duplicates, so cursor themes are duplicated in the UI.

The details of this are in bug #273744

I have checked the configure script, which has some simple check to try to avid
such duplicates, but actually fails due to variable substitutions being
performed in multiple steps and the check for equal variables fails to catch
our path.

So, to avoid this, I thought we could directly pass the full xcursor search
path with the configure --with-cursorpath variable, so we have full control
over it.

Testing in poudriere shows it does what it is expected, I'm going to run test
it on my machines as soon the build run ends.

Can this be approved?

Thanks in advance.


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273744
[Bug 273744] sysutils/xfce4-settings: cursor themes being listed twice
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.