maintainer-feedback requested: [Bug 273806] x11/libXcursor: Avoid duplicated path in XCURSORPATH

Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-x11 (Nobody)
<x11@FreeBSD.org> for maintainer-feedback:
Bug 273806: x11/libXcursor: Avoid duplicated path in XCURSORPATH
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273806



--- Description ---
by default libXcursor is being build passing to it an ICONDIR that causes the
configure script to define an XCURSORPATH with that value duplicated. This can
be seen in any build log, the cc commands get this argument:

-DXCURSORPATH=\"~/.local/share/icons:~/.icons:/usr/local/share/icons:/usr/local
/share/pixmaps:/usr/local/share/icons\"


This is causing issues with xfce4-mouse-settings from xfce4-settings port,
which scans this path for cursor themes. This software performs no checks for
duplicates, so cursor themes are duplicated in the UI.

The details of this are in bug #273744

I have checked the configure script, which has some simple check to try to avid
such duplicates, but actually fails due to variable substitutions being
performed in multiple steps and the check for equal variables fails to catch
our path.

So, to avoid this, I thought we could directly pass the full xcursor search
path with the configure --with-cursorpath variable, so we have full control
over it.

Testing in poudriere shows it does what it is expected, I'm going to run test
it on my machines as soon the build run ends.

Can this be approved?

Thanks in advance.