Re: iwlwifi / rtw88 / rtw89 hw crypto request for test (precon for HT/VHT)

On Wed, 19 Feb 2025, ltning-freebsd-wireless@anduin.net wrote:

Hi,

> All good on my Framework 13:
>
> iwlwifi0@pci0:170:0:0:    class=0x028000 rev=0x1a hdr=0x00 vendor=0x8086 
> device=0x2725 subvendor=0x8086 subdevice=0x0020
>
> No obvious differences from before. I have a feeling it might be a tad faster 
> than before - especially under high CPU load - but that may also be entirely 
> placebo.

I would not expect this to be noticable with the current state.
As indicated in the original message it is a prerequisite for going
to the next step.

> Btw I'm not able to build tools/tools/net80211/wlanstats. Build log attached. 
> I'll pull down newer source and rebuild (since it's later been moved to 
> usr/sbin) but I am not at liberty to do that right now.

Yes, I had to fix that when I moved it into usr.sbin;  it seemed one of
the maros used was removed in Decemeber 2024.

If you want to build it in tools, I think this bit will fix it (just
pasted in):

@@ -460,8 +460,8 @@ getlladdr(struct wlanstatfoo_p *wf)
         if (p == NULL)
                 errx(1, "did not find link layer address for interface %s",
                         wf->ifr.ifr_name);
-       sdl = (const struct sockaddr_dl *) p->ifa_addr;
-       IEEE80211_ADDR_COPY(wf->mac, CLLADDR(sdl));
+       sdl = (const struct sockaddr_dl *)(const void *)p->ifa_addr;
+       IEEE80211_ADDR_COPY(wf->mac, sdl->sdl_data + sdl->sdl_nlen);
         freeifaddrs(ifp);
  }


Thanks a lot for testing and reporting back!

Bjoern

-- 
Bjoern A. Zeeb                                                     r15:7