Re: iwlwifi / rtw88 / rtw89 hw crypto request for test (precon for HT/VHT)

All good on my Framework 13:

iwlwifi0@pci0:170:0:0:    class=0x028000 rev=0x1a hdr=0x00 vendor=0x8086 
device=0x2725 subvendor=0x8086 subdevice=0x0020

No obvious differences from before. I have a feeling it might be a tad 
faster than before - especially under high CPU load - but that may also 
be entirely placebo.

Attached a snipped from wpa_supplicant log from one of the periodic key 
renewals or whatever it is. Not sure if it's interesting at all.

Btw I'm not able to build tools/tools/net80211/wlanstats. Build log 
attached. I'll pull down newer source and rebuild (since it's later been 
moved to usr/sbin) but I am not at liberty to do that right now.

/Eirik

On 18.02.2025 05:01, Bjoern A. Zeeb wrote:
> Hi,
> 
> with [1] I added HW_CRYPTO support to the build for all LinuxKPI based
> drivers.  This is a pre-condition to make HT/VHT work with drivers/fw
> which support, e.g., A-MPDU offloading -- basically almost everything
> modern.
> 
> I will very likely MFC it at the end of the week if I didn't put in any
> last minute bugs.
> 
> As the commit message says it currently only supports CCMP.  If you
> still do WEP or TKIP please let me know and I'll add it to the list
> though I'll then likely want your help to test (patches) as well.
> 
> As also mentioned in the commit message I saw one specific panic in the
> past which I no longer can reproduce.  I am sure there's some other edge
> cases on more devices so I need your help to test.
> 
> While the code is compiled in now it is disabled behind a tunable until
> there is sufficient feedback for iwlwifi, rtw88 and rtw89 that it works.
> Once that happens I'll flip the default for the tunable at least to on
> and eventually remove it alltogether and we can move to the next steps
> of testing which is hopefully fully merged to git by then.
> 
> So if you want some HT/VHT to work with at least modern iwlwifi, and then
> also older iwlwifi, rtw88 and rtw89 in th enext steps please help testing
> and report back the next days.
> 
> To turn the code on add the following line to laoder.conf:
>      compat.linuxkpi.80211.hw_crypto=1
> 
> At runtime you can check the state by using:
>      sysctl compat.linuxkpi.80211.hw_crypto
> 
> Also if you have any problems, then you can easily remove that line (or
> unset it from loader) and boot with the support turned on.
> 
> If you reply to this thread or me (positive or negative feedback), please
> add the pciconf -l line for your wifi card so we known about the chipset.
> 
> 
> Lots of joy,
> Bjoern
> 
> [1] https://cgit.FreeBSD.org/src/commit/? 
> id=11db70b6057e41b259dc2245cd893d5b19179fcc
>