Re: iwlwifi / rtw88 / rtw89 hw crypto request for test (precon for HT/VHT)

On Tue, 18 Feb 2025, Bjoern A. Zeeb wrote:

> Hi,
>
> with [1] I added HW_CRYPTO support to the build for all LinuxKPI based
> drivers.  This is a pre-condition to make HT/VHT work with drivers/fw
> which support, e.g., A-MPDU offloading -- basically almost everything
> modern.
>
> I will very likely MFC it at the end of the week if I didn't put in any
> last minute bugs.
>
> As the commit message says it currently only supports CCMP.  If you
> still do WEP or TKIP please let me know and I'll add it to the list
> though I'll then likely want your help to test (patches) as well.
>
> As also mentioned in the commit message I saw one specific panic in the
> past which I no longer can reproduce.  I am sure there's some other edge
> cases on more devices so I need your help to test.
>
> While the code is compiled in now it is disabled behind a tunable until
> there is sufficient feedback for iwlwifi, rtw88 and rtw89 that it works.
> Once that happens I'll flip the default for the tunable at least to on
> and eventually remove it alltogether and we can move to the next steps
> of testing which is hopefully fully merged to git by then.
>
> So if you want some HT/VHT to work with at least modern iwlwifi, and then
> also older iwlwifi, rtw88 and rtw89 in th enext steps please help testing
> and report back the next days.
>
> To turn the code on add the following line to laoder.conf:
> 	compat.linuxkpi.80211.hw_crypto=1
>
> At runtime you can check the state by using:
> 	sysctl compat.linuxkpi.80211.hw_crypto
>
> Also if you have any problems, then you can easily remove that line (or
> unset it from loader) and boot with the support turned on.
>
> If you reply to this thread or me (positive or negative feedback), please
> add the pciconf -l line for your wifi card so we known about the chipset.

People asked me 'what should I look for apart from that it works".

I just moved wlanstats into usr.sbin out of tools.
wlanstats would report crypto errors (only if there are any), e.g.,
"rx seq# violation (CCMP)".

Would be interesting to check for that, espsecially if you have "stalls
over key changes" (check the wpa_supplicant log for timestamps) or other
problems that stop passing traffic.

You can check that there is no logging in dmesg.  On a different laptop
I just managed to get
iwlwifi0: _lkpi_iv_key_set: sta 01:23:45:67:89:ab found with key information

Apart from that I am also happy to hear that there are no firmware
crashes or panics ;-)


And thanks to everyone who has already reported back.

/bz

> Lots of joy,
> Bjoern
>
> [1] 
> https://cgit.FreeBSD.org/src/commit/?id=11db70b6057e41b259dc2245cd893d5b19179fcc
>
>

-- 
Bjoern A. Zeeb                                                     r15:7