From nobody Wed Feb 19 03:11:23 2025 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YyLyS1J76z5nctn for ; Wed, 19 Feb 2025 03:11:28 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YyLyR1SZpz3SNt for ; Wed, 19 Feb 2025 03:11:27 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739934687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CTYF6Z7v3HEjDMUNKHifWfSPTdgXDvvfhGKg7SXvtjw=; b=Q++b3L26iEbZ1c6HibwlLFqXuwYYqWPNEqkos7jmCOfEthX1vgv61w70tfdiJwyxly0gne 6k+19cSwNGhyu1Gn57LxbyQs2rWDdX6nYhSZvzPho17616zAzJlZQOyuNv1qVLLcZTq7Ke 89z/jcnP7K2syOY5bM2g4+2vk/SqME+H9p1h2Bu3V5roaIH+VBndVlbVyRddyfElOTvil9 noH9xIzMGVPEHkNn9/b3IYhT7EPxCBfgaJ1gadCbyzT/eruzpQRGFte5qed2CTDNnrV3u8 71Auft3+lhSUBCsWv1OZ+hZs7J/0xbTOZH1RuHRwpxLQjCx/mJTNWtjeCFr8IQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739934687; a=rsa-sha256; cv=none; b=vWaiDRqDffU5sI4wsfpVU4vZ+m3rliy1RZXCwxDcCePlqlBFp987MX+FY3L+4O60/kbD8U 6RHK/cdogLcvE15ppEwEi5zCMo6lLFFeGOWLxEQCQbGr6b3at5MpB5ri6mXHm/+6bZ7i3m dMkWXWPWRcgPKuLluB5ktTruPrqbx77MqSR5B1chjK1r9Tu26uP85Wem/vCMMTQvluN5JK b5Se6AoSZipM1K3hhQGrP98R9JdOSgYw6A38oi5YseSawqtVhD0m7GwU+ogmOX04OOTpaL ELgRjgQwpt69YSKsmwmXVOBONei2u62XFBz6zuiRxsNhj6+XNI7ePFdtyd5aRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739934687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CTYF6Z7v3HEjDMUNKHifWfSPTdgXDvvfhGKg7SXvtjw=; b=FU3RU8GGHFQR8jzxVp8ffSu1yXXFb+q4dONKqvsoPoFzqx3oFIL8rrEEOytzcyMLZ7hZ6U QxvXlf2Cm7y1fsbmz09xv9y3y24+e1RjndSwqcceDzuJ4Vrdy91G0mZSu3q06vqSyn7/r5 CVWYkpa3azVpczeIheAWnwOyD8q2wzzPUazQsUrZpB0Vw94YtWC497+Ia0kXn9LtpOxu/h TJ7Ii9XDDmwDjP3muz5ogF60v9U0AaW5gswVSQo3Bmd3gcumnwu1rptjkq/d4E3klMm9gN 5aeaNU+n0nG8Zdh3kLa/HuOPiQFZclPKEvj5OKPL3m2Y8U3w/AuGfhHPRgTZBA== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E5" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YyLyR04Fvz16BK for ; Wed, 19 Feb 2025 03:11:26 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 369E1A64805 for ; Wed, 19 Feb 2025 03:11:24 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 2D52A2D029DF for ; Wed, 19 Feb 2025 03:11:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id n4t-K0mUt-wL for ; Wed, 19 Feb 2025 03:11:24 +0000 (UTC) Received: from strong-rtwn0.sbone.de (strong-rtwn0.sbone.de [IPv6:fde9:577b:c1a9:4902:da44:89ff:fedd:d5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 0E8602D029D8 for ; Wed, 19 Feb 2025 03:11:24 +0000 (UTC) Date: Wed, 19 Feb 2025 03:11:23 +0000 (UTC) From: "Bjoern A. Zeeb" To: FreeBSD wireless mailing list Subject: Re: iwlwifi / rtw88 / rtw89 hw crypto request for test (precon for HT/VHT) In-Reply-To: Message-ID: <21qrn616-1q77-oq5n-0508-705s152n18qr@SerrOFQ.bet> References: X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-wireless@freebsd.org Sender: owner-freebsd-wireless@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 18 Feb 2025, Bjoern A. Zeeb wrote: > Hi, > > with [1] I added HW_CRYPTO support to the build for all LinuxKPI based > drivers. This is a pre-condition to make HT/VHT work with drivers/fw > which support, e.g., A-MPDU offloading -- basically almost everything > modern. > > I will very likely MFC it at the end of the week if I didn't put in any > last minute bugs. > > As the commit message says it currently only supports CCMP. If you > still do WEP or TKIP please let me know and I'll add it to the list > though I'll then likely want your help to test (patches) as well. > > As also mentioned in the commit message I saw one specific panic in the > past which I no longer can reproduce. I am sure there's some other edge > cases on more devices so I need your help to test. > > While the code is compiled in now it is disabled behind a tunable until > there is sufficient feedback for iwlwifi, rtw88 and rtw89 that it works. > Once that happens I'll flip the default for the tunable at least to on > and eventually remove it alltogether and we can move to the next steps > of testing which is hopefully fully merged to git by then. > > So if you want some HT/VHT to work with at least modern iwlwifi, and then > also older iwlwifi, rtw88 and rtw89 in th enext steps please help testing > and report back the next days. > > To turn the code on add the following line to laoder.conf: > compat.linuxkpi.80211.hw_crypto=1 > > At runtime you can check the state by using: > sysctl compat.linuxkpi.80211.hw_crypto > > Also if you have any problems, then you can easily remove that line (or > unset it from loader) and boot with the support turned on. > > If you reply to this thread or me (positive or negative feedback), please > add the pciconf -l line for your wifi card so we known about the chipset. People asked me 'what should I look for apart from that it works". I just moved wlanstats into usr.sbin out of tools. wlanstats would report crypto errors (only if there are any), e.g., "rx seq# violation (CCMP)". Would be interesting to check for that, espsecially if you have "stalls over key changes" (check the wpa_supplicant log for timestamps) or other problems that stop passing traffic. You can check that there is no logging in dmesg. On a different laptop I just managed to get iwlwifi0: _lkpi_iv_key_set: sta 01:23:45:67:89:ab found with key information Apart from that I am also happy to hear that there are no firmware crashes or panics ;-) And thanks to everyone who has already reported back. /bz > Lots of joy, > Bjoern > > [1] > https://cgit.FreeBSD.org/src/commit/?id=11db70b6057e41b259dc2245cd893d5b19179fcc > > -- Bjoern A. Zeeb r15:7