Re: rtwn0: rtwn_rx_copy_to_mbuf: could not allocate RX mbuf

change

__func__);

to

__func__, totlen);


On Fri, 25 Apr 2025 at 16:30, Nuno Teixeira <eduardo@freebsd.org> wrote:

> (...)
>
> kk, it builds fine without patch.
>
> Sending logs of the patch (as gmail ruins formating) and kernel.log
> attached.
>
> Nuno Teixeira <eduardo@freebsd.org> escreveu (sábado, 26/04/2025 à(s)
> 00:18):
> >
> > Hum build kernel is failing with:
> >
> > diff --git a/sys/dev/rtwn/usb/rtwn_usb_rx.c
> b/sys/dev/rtwn/usb/rtwn_usb_rx.c
> > index 657d6bdeb9e4..15e7da2b1968 100644
> > --- a/sys/dev/rtwn/usb/rtwn_usb_rx.c
> > +++ b/sys/dev/rtwn/usb/rtwn_usb_rx.c
> > @@ -126,7 +126,7 @@ rtwn_rx_copy_to_mbuf(struct rtwn_softc *sc, struct
> > rtwn_rx_stat_common *stat,
> >
> >         m = m_get2(totlen, M_NOWAIT, MT_DATA, M_PKTHDR);
> >         if (__predict_false(m == NULL)) {
> > -               device_printf(sc->sc_dev, "%s: could not allocate RX
> mbuf\n",
> > +               device_printf(sc->sc_dev, "%s: could not allocate RX
> > mbuf (%d bytes)\n",
> >                     __func__);
> >                 goto fail;
> >         }
> >
> > I will rebuild it again without patch and check what is the problem
> >
> > Nuno Teixeira <eduardo@freebsd.org> escreveu (sábado, 26/04/2025 à(s)
> 00:12):
> > >
> > > I'm compiling and soon I will reboot.
> > > Do the tests the same way and previous email or just trigger error and
> > > capture logs?
> > >
> > > Adrian Chadd <adrian.chadd@gmail.com> escreveu (sábado, 26/04/2025
> à(s) 00:04):
> > > >
> > > >
> > > >
> > > > On Fri, 25 Apr 2025 at 16:03, Nuno Teixeira <eduardo@freebsd.org>
> wrote:
> > > >>
> > > >> > edit sys/dev/rtwn/usb/usb_rtwn_rx.c ,around line 129. Change that
> device_printf() line to
> > > >> >
> > > >> > device_printf(sc->sc_dev, "%s: could not allocate RX mbuf (%d
> bytes)\n",
> > > >> >     __func__, totlen);
> > > >>
> > > >> # cd /usr/src
> > > >> # find . -name "*rtwn_rx.c"
> > > >> ./sys/dev/rtwn/if_rtwn_rx.c
> > > >>
> > > >> Where is sys/dev/rtwn/usb/usb_rtwn_rx.c ?
> > > >>
> > > >
> > > > /usr/src/sys/dev/rtwn/usb/rtwn_usb_rx.c
> > > >
> > > > sorry, typo. :-0
> > > >
> > > >
> > > >
> > > > -adrian
> > > >
> > > >>
> > > >> --
> > > >> Nuno Teixeira
> > > >> FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org
> > >
> > >
> > >
> > > --
> > > Nuno Teixeira
> > > FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org
> >
> >
> >
> > --
> > Nuno Teixeira
> > FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org
>
>
>
> --
> Nuno Teixeira
> FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org
>