From nobody Fri Apr 25 23:50:48 2025 X-Original-To: freebsd-wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZkqNp429Dz5tGNT for ; Fri, 25 Apr 2025 23:51:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZkqNm6dFtz3P2x; Fri, 25 Apr 2025 23:51:04 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-54d65cb6e8aso3555706e87.1; Fri, 25 Apr 2025 16:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745625061; x=1746229861; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Vk12ljmcwYkQHpp8/+FmBUXZ0uij1a6hRSB2zl0jId8=; b=T4qg9ndtCuD52KQ9E/m83GsAv+X41BgluUEKBY4KjJTtjOuFJYu4RZFdfUJAwY7e8M 0Yl2uQhOP2CJZeY40943tDIzwpaQ6lUp5T1Qa1hEnqIbgut+V5HrXOQHsqM3MCZIjsXk gj7iWsIgmOXb9H8dNXGFEbnnhm1BYuanYJPxCJ+frVVR/lMieyDSCyFpi9lstFei3fsY dFE41/XtGgUYE/Wzx/qTransN+1hj6WqBMRaVIzm16ybrkuu7ZKpsbBkF5XrYTSqS6Yd BcMzGpyekBD4fFR5exDUr5WenFKYuEmh5102pWdl3MMdmJnAKx6Ayoj5HlfDKqT1o/u1 dNLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745625061; x=1746229861; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vk12ljmcwYkQHpp8/+FmBUXZ0uij1a6hRSB2zl0jId8=; b=MLKsH3vz96HrqkZ2fcO0F8g6M0LSe5SLV6BZkCmo0T1ru1/DAFIsVAuU0wj5Cug6aV oWNe0h5xE8SQAucaOiK4Pm+X8wtf0kMvK0CilVUcsMCASeBTSh1pJAn0NEHfVY4bt29o 2XLPGBHiVzlugMKDEamWBT0fc40QXkqCfTMNCZ+dDYSlvpha1szBec3cEJj8THRMhYDR WfJ39l5+IpyM1KkHZlNPWfSFP3VbiUJI50v1QoHBVnf8lg6jK8VNt85dOIs7NbEBRl3r iUB2+d4y9DgadZuMdeq8M9nO9neNdLOHYb8F0oRxBoZ86QLf+1zAZercWeXkJG2eZyYE ScjQ== X-Gm-Message-State: AOJu0YyHmQ4aGSmA0H+REO8tAR4tyc8iI/JZmbCkOs+LKT8uIgwCdb1p 3IOiLGzmXc4gBXHZb4JAGTPu+1qvKfua1UGYHZ3mXnsgYQrfyvgcyKQmUDlf9jL//QaWVD5QfdV kHzjtBB80S3Qay3cbtARBTQMv9KaYXw== X-Gm-Gg: ASbGnctn1gznyznJa1Xi9nvA141Ty8FYf1K35dwhGt7ov0NwpljwtWG0N1Wbk4L8mKC XzIuZQSsMYrKRpluqErmXr2n2xmJYgHL1T2P+ZOHpaJXh6FFPe7HwrVF7YpYHLjjrlGo960fdjl zCF1YsHutTLV8dd0Q/ldZap0Q= X-Google-Smtp-Source: AGHT+IER4M3uT4xNcMvNQc4ZvJh5Wf1xJ0HESkxHtASTJxHUWIkX2yCFprh50Fuo/rdTlPfFMthrd3QxHdJzeqYxdTQ= X-Received: by 2002:a05:651c:1442:b0:30d:b93d:a210 with SMTP id 38308e7fff4ca-319085be6b8mr14508571fa.36.1745625060787; Fri, 25 Apr 2025 16:51:00 -0700 (PDT) List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-wireless@freebsd.org Sender: owner-freebsd-wireless@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Fri, 25 Apr 2025 16:50:48 -0700 X-Gm-Features: ATxdqUEs7I1LlCs3h5xAXTlXmpy20H0xL1ohIvmPYbmTBUebPMD3LkAiehXAjLw Message-ID: Subject: Re: rtwn0: rtwn_rx_copy_to_mbuf: could not allocate RX mbuf To: Nuno Teixeira Cc: freebsd-wireless@freebsd.org Content-Type: multipart/alternative; boundary="000000000000a8ccd50633a30177" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4ZkqNm6dFtz3P2x X-Spamd-Bar: ---- --000000000000a8ccd50633a30177 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable change __func__); to __func__, totlen); On Fri, 25 Apr 2025 at 16:30, Nuno Teixeira wrote: > (...) > > kk, it builds fine without patch. > > Sending logs of the patch (as gmail ruins formating) and kernel.log > attached. > > Nuno Teixeira escreveu (s=C3=A1bado, 26/04/2025 =C3= =A0(s) > 00:18): > > > > Hum build kernel is failing with: > > > > diff --git a/sys/dev/rtwn/usb/rtwn_usb_rx.c > b/sys/dev/rtwn/usb/rtwn_usb_rx.c > > index 657d6bdeb9e4..15e7da2b1968 100644 > > --- a/sys/dev/rtwn/usb/rtwn_usb_rx.c > > +++ b/sys/dev/rtwn/usb/rtwn_usb_rx.c > > @@ -126,7 +126,7 @@ rtwn_rx_copy_to_mbuf(struct rtwn_softc *sc, struct > > rtwn_rx_stat_common *stat, > > > > m =3D m_get2(totlen, M_NOWAIT, MT_DATA, M_PKTHDR); > > if (__predict_false(m =3D=3D NULL)) { > > - device_printf(sc->sc_dev, "%s: could not allocate RX > mbuf\n", > > + device_printf(sc->sc_dev, "%s: could not allocate RX > > mbuf (%d bytes)\n", > > __func__); > > goto fail; > > } > > > > I will rebuild it again without patch and check what is the problem > > > > Nuno Teixeira escreveu (s=C3=A1bado, 26/04/2025 = =C3=A0(s) > 00:12): > > > > > > I'm compiling and soon I will reboot. > > > Do the tests the same way and previous email or just trigger error an= d > > > capture logs? > > > > > > Adrian Chadd escreveu (s=C3=A1bado, 26/04/20= 25 > =C3=A0(s) 00:04): > > > > > > > > > > > > > > > > On Fri, 25 Apr 2025 at 16:03, Nuno Teixeira > wrote: > > > >> > > > >> > edit sys/dev/rtwn/usb/usb_rtwn_rx.c ,around line 129. Change tha= t > device_printf() line to > > > >> > > > > >> > device_printf(sc->sc_dev, "%s: could not allocate RX mbuf (%d > bytes)\n", > > > >> > __func__, totlen); > > > >> > > > >> # cd /usr/src > > > >> # find . -name "*rtwn_rx.c" > > > >> ./sys/dev/rtwn/if_rtwn_rx.c > > > >> > > > >> Where is sys/dev/rtwn/usb/usb_rtwn_rx.c ? > > > >> > > > > > > > > /usr/src/sys/dev/rtwn/usb/rtwn_usb_rx.c > > > > > > > > sorry, typo. :-0 > > > > > > > > > > > > > > > > -adrian > > > > > > > >> > > > >> -- > > > >> Nuno Teixeira > > > >> FreeBSD UNIX: Web: https://FreeBSD.org > > > > > > > > > > > > -- > > > Nuno Teixeira > > > FreeBSD UNIX: Web: https://FreeBSD.org > > > > > > > > -- > > Nuno Teixeira > > FreeBSD UNIX: Web: https://FreeBSD.org > > > > -- > Nuno Teixeira > FreeBSD UNIX: Web: https://FreeBSD.org > --000000000000a8ccd50633a30177 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
change

__func__);

<= div>to

__func__, totlen);


On Fri, 25 Apr 2025 at 16:30, Nuno Teixeira <eduardo@freebsd.org> wrote:
(...)

kk, it builds fine without patch.

Sending logs of the patch (as gmail ruins formating) and kernel.log attache= d.

Nuno Teixeira <= eduardo@freebsd.org> escreveu (s=C3=A1bado, 26/04/2025 =C3=A0(s) 00:= 18):
>
> Hum build kernel is failing with:
>
> diff --git a/sys/dev/rtwn/usb/rtwn_usb_rx.c b/sys/dev/rtwn/usb/rtwn_us= b_rx.c
> index 657d6bdeb9e4..15e7da2b1968 100644
> --- a/sys/dev/rtwn/usb/rtwn_usb_rx.c
> +++ b/sys/dev/rtwn/usb/rtwn_usb_rx.c
> @@ -126,7 +126,7 @@ rtwn_rx_copy_to_mbuf(struct rtwn_softc *sc, struct=
> rtwn_rx_stat_common *stat,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0m =3D m_get2(totlen, M_NOWAIT, MT_DAT= A, M_PKTHDR);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (__predict_false(m =3D=3D NULL)) {=
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0device_printf(= sc->sc_dev, "%s: could not allocate RX mbuf\n",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0device_printf(= sc->sc_dev, "%s: could not allocate RX
> mbuf (%d bytes)\n",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0__func__);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0goto fail= ;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>
> I will rebuild it again without patch and check what is the problem >
> Nuno Teixeira <eduardo@freebsd.org> escreveu (s=C3=A1bado, 26/04/2025 =C3=A0(s= ) 00:12):
> >
> > I'm compiling and soon I will reboot.
> > Do the tests the same way and previous email or just trigger erro= r and
> > capture logs?
> >
> > Adrian Chadd <adrian.chadd@gmail.com> escreveu (s=C3=A1bado, 26/04/202= 5 =C3=A0(s) 00:04):
> > >
> > >
> > >
> > > On Fri, 25 Apr 2025 at 16:03, Nuno Teixeira <eduardo@freebsd.org> wr= ote:
> > >>
> > >> > edit sys/dev/rtwn/usb/usb_rtwn_rx.c ,around line 12= 9. Change that device_printf() line to
> > >> >
> > >> > device_printf(sc->sc_dev, "%s: could not al= locate RX mbuf (%d bytes)\n",
> > >> >=C2=A0 =C2=A0 =C2=A0__func__, totlen);
> > >>
> > >> # cd /usr/src
> > >> # find . -name "*rtwn_rx.c"
> > >> ./sys/dev/rtwn/if_rtwn_rx.c
> > >>
> > >> Where is sys/dev/rtwn/usb/usb_rtwn_rx.c ?
> > >>
> > >
> > > /usr/src/sys/dev/rtwn/usb/rtwn_usb_rx.c
> > >
> > > sorry, typo. :-0
> > >
> > >
> > >
> > > -adrian
> > >
> > >>
> > >> --
> > >> Nuno Teixeira
> > >> FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 = =C2=A0Web:=C2=A0 https://FreeBSD.org
> >
> >
> >
> > --
> > Nuno Teixeira
> > FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:= =C2=A0 https://FreeBSD.org
>
>
>
> --
> Nuno Teixeira
> FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0= https= ://FreeBSD.org



--
Nuno Teixeira
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--000000000000a8ccd50633a30177--