Re: rtw88 import to main

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--0-1276364220-1649029109=:68830
Content-Type: TEXT/PLAIN; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Sun, 3 Apr 2022, Daniel Pérez wrote:

>
> Update: after changing my interface settings, I finally got wifi (I had some problems with my wpa_supplicant config and the default route).
> Managed to connect to my dual-band connection in mode 11g, getting around 7.3Mbps of download speed (which is very acceptable at this state).
>
> Wifi seems to be stable, though when performing the speed test, the upload failed and got this in dmesg:
>
> Limiting closed port RST response from 216 to 200 packets/sec
>
> And when repeating it I got this message repeated numerous times (above 100):
> rtw880: failed to write TX skb to HCI

Hmm, silly error reporting.  Can you try the below change so we know more
in case it happens again.

--------------------------------------------------------------------------------
diff --git sys/contrib/dev/rtw88/tx.c sys/contrib/dev/rtw88/tx.c
index efcc1b0371a8..5a02553b3b63 100644
--- sys/contrib/dev/rtw88/tx.c
+++ sys/contrib/dev/rtw88/tx.c
@@ -515,7 +515,11 @@ void rtw_tx(struct rtw_dev *rtwdev,
         rtw_tx_pkt_info_update(rtwdev, &pkt_info, control->sta, skb);
         ret = rtw_hci_tx_write(rtwdev, &pkt_info, skb);
         if (ret) {
+#if defined(__linux__)
                 rtw_err(rtwdev, "failed to write TX skb to HCI\n");
+#elif defined(__FreeBSD__)
+               rtw_err(rtwdev, "%s: failed to write TX skb to HCI: %d\n", __func__, ret);
+#endif
                 goto out;
         }

@@ -572,7 +576,11 @@ static int rtw_txq_push_skb(struct rtw_dev *rtwdev,
         rtw_tx_pkt_info_update(rtwdev, &pkt_info, txq->sta, skb);
         ret = rtw_hci_tx_write(rtwdev, &pkt_info, skb);
         if (ret) {
+#if defined(__linux__)
                 rtw_err(rtwdev, "failed to write TX skb to HCI\n");
+#elif defined(__FreeBSD__)
+               rtw_err(rtwdev, "%s: failed to write TX skb to HCI: %d\n", __func__, ret);
+#endif
                 return ret;
         }
         rtwtxq->last_push = jiffies;
--------------------------------------------------------------------------------

You could also possibly try setting the two sysctls I just posted in the other email to wireless to disable power save.


> Still had connection, though.
>
> All this was done limiting memory to 4G.
>
> Finally seeing some light in the tunnel.

Yeah! :)   Thanks a lot for keeping testing and reporting back.


Bjoern

-- 
Bjoern A. Zeeb                                                     r15:7
--0-1276364220-1649029109=:68830--