Re: [PATCH] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

From: Corvin Köhne <corvink_at_FreeBSD.org>
Date: Thu, 06 Apr 2023 06:16:43 UTC
On Wed, 2023-04-05 at 07:54 +1000, Peter Grehan wrote:
> > Using the qemu fwcfg has one big disadvantage:
> > Bhyve's fwctl and qemu's fwcfg can't be used at the same time. Due
> > to
> > backward compatibility reasons, bhyve uses fwctl as default. So,
> > using
> > qemu's fwcfg to locate the rsdp only works, if the user changes his
> > bhyve call.
> > I don't want to use fwctl to locate the rsdp because IMHO we should
> > migrate to fwcfg. So, we shouldn't add new features to fwctl.
> 
>   Ah ok.
> 

I take this as confirmation. If no one else complains, I'm going to
send this patch to the EDKII project next week.

> > Btw: I'm also preparing some patches to support qemu's acpi table
> > loader. So, if we like to use qemu's fwcfg, we should use the
> > loader
> > instead of an own baked solution.
> 
>   Yes: that's a much better solution. The bhyve-generated ones are
> very 
> size-limited.
> 

FYI: https://reviews.freebsd.org/D38438 and
https://reviews.freebsd.org/D38439 add support for qemu's table loader
to bhyve.


-- 
Kind regards,
Corvin