[Bug 262141] Pervasive Typo Issue in SRC NVMe Code

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 23 Feb 2022 08:30:00 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262141

            Bug ID: 262141
           Summary: Pervasive Typo Issue in SRC NVMe Code
           Product: Base System
           Version: 13.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: bhyve
          Assignee: virtualization@FreeBSD.org
          Reporter: fgorter@gmail.com

Hello All,

Found something of a nasty typo in the following 3 branches (all AMD64,
possibly more...) 13.0-RELEASE, 13.0-STABLE and 14-CURRENT (still present, just
checked 5 mins ago)
The file involved is located at /usr/include/dev/nvme/nvme.h
The issue can be found around line 1284-ish, specifically:

NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS = 0x0c,

To the most OCD-afflicted of us, will find the obvious typo, that NAMESPACE is
*not* spelled with a "V".
The issue revealed itself to me while attempting to build
/usr/ports/sysutils/bhyve+/ on a 14-CURRENT machine and complaints about
"NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS" caused a break in the port build.

The fix is obviously simple, replace NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS with
NVME_LOG_ASYMMETRIC_NAMESPACE_ACCESS, note the word NAMESPACE is spelled with a
"C".

Hope this helps the community.

-- 
You are receiving this mail because:
You are the assignee for the bug.