From nobody Wed Feb 23 08:30:00 2022 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 231D019E2A68 for ; Wed, 23 Feb 2022 08:30:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K3Tk0646xz4YBT for ; Wed, 23 Feb 2022 08:30:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AC4E714F44 for ; Wed, 23 Feb 2022 08:30:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21N8U0Mm001813 for ; Wed, 23 Feb 2022 08:30:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21N8U00S001812 for virtualization@FreeBSD.org; Wed, 23 Feb 2022 08:30:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 262141] Pervasive Typo Issue in SRC NVMe Code Date: Wed, 23 Feb 2022 08:30:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: fgorter@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645605000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fGw92R7qbiEoUJv9sD08KCMOn6zHVEqGAp+ul1QBKEU=; b=rF9tOKi626dVbREGxqqxuo5oAQDuNPkzYySFshe+lm5hdJ0DqUz97f8rutTrjgVnogPCV4 jVd9YqPA5XUVXdZu9VUqHJKgKeNigIpOy5jlwojoYcbKzMM4wotIwOfqvENJ+KciP2WmDE NtlLCBNigkQ19A3xX99Hjq6M3PDDOH+jk2JbFlJH1/lq1IuHlgTcEv1SB3GrfvLL2xz33a bi96bBkk0RyWA6R1cehlUrNEJMYhrEruyIJ8/4Nj33x6Sv8m+SqBzHbc1/RgQVWU7R8MdB XOzhc4b3/0HzDSuOvwh/mBrVCzq8BuDTr20DxhwQVNgOWeB3+GhImrO872ZrSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645605000; a=rsa-sha256; cv=none; b=AtOKkGecbaJyr5KT5bBItc39D4GvAJJj1Wn8kmaaoe6Lm0Ci2I1CQaVvCjtpaQPkgEO3RJ FiOHQHGKrnkclDzGVTc5DqubNI3SR7SVW2fE3cPb+WGCO7IgewYchI/h3hf5IwNsiA4vNv 1+Qvd0zXdD4FFSn/sOOmLS9XIr4Vs1ruR8Zw5AtXJorj0ezGidcS+Mg8DtD/FfNyvxzkbR GIGaiPkKPrQcctmlpy4D1wc9G0DI+taerFFsNjwQ3Br2vjd226jjIh906YQOtXwhN6TgaD T3VTYXbYUHNSn11+a7XaS51R7MmJkFDZvjXSxmn2NbvYS6pYlqujiVNGNOPoKw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262141 Bug ID: 262141 Summary: Pervasive Typo Issue in SRC NVMe Code Product: Base System Version: 13.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bhyve Assignee: virtualization@FreeBSD.org Reporter: fgorter@gmail.com Hello All, Found something of a nasty typo in the following 3 branches (all AMD64, possibly more...) 13.0-RELEASE, 13.0-STABLE and 14-CURRENT (still present, = just checked 5 mins ago) The file involved is located at /usr/include/dev/nvme/nvme.h The issue can be found around line 1284-ish, specifically: NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS =3D 0x0c, To the most OCD-afflicted of us, will find the obvious typo, that NAMESPACE= is *not* spelled with a "V". The issue revealed itself to me while attempting to build /usr/ports/sysutils/bhyve+/ on a 14-CURRENT machine and complaints about "NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS" caused a break in the port build. The fix is obviously simple, replace NVME_LOG_ASYMMETRIC_NAMESPAVE_ACCESS w= ith NVME_LOG_ASYMMETRIC_NAMESPACE_ACCESS, note the word NAMESPACE is spelled wi= th a "C". Hope this helps the community. --=20 You are receiving this mail because: You are the assignee for the bug.=