Re: Adding some consistency to /etc/rc.d/*
- In reply to: Jamie Landeg-Jones : "Re: Adding some consistency to /etc/rc.d/*"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 27 Sep 2025 10:48:13 UTC
On 07/09/2025 23:59, Jamie Landeg-Jones wrote: > "Dan Mahoney (Ports)" <freebsd@gushi.org> wrote: > >> Here was a pull request for ntpd. It mostly involved removing quotes from variable names, formatting functions consistently, and reordering a few functions at the top: https://github.com/freebsd/freebsd-src/compare/main...thegushi:freebsd-src:rclint-ntpd > > Do we actually have any style convention applicable here? > > I personally prefer to quote strings, even though I know exactly where and when they are needed. > > I like the idea of this program, but in the case of quoting, the above linked result looks worse in my opinion. > > I know it's not authorative, but googles style guide agrees: https://google.github.io/styleguide/shellguide.html Unquoted strings seems strange to me too. Few lines without quotes followed by one line with quotes then another line without quotes... I think it does not help anything / anybody. If I can vote, I vote for quoted strings. (and the diff will be smaller) Kind regards Miroslav Lachman