From nobody Sat Sep 27 10:48:13 2025 X-Original-To: freebsd-rc@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cYkhF2bDjz6994J for ; Sat, 27 Sep 2025 10:48:29 +0000 (UTC) (envelope-from SRS0=mZYy=4G=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cYkh939wfz3WrV; Sat, 27 Sep 2025 10:48:25 +0000 (UTC) (envelope-from SRS0=mZYy=4G=quip.cz=000.fbsd@elsa.codelab.cz) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=quip.cz header.s=private header.b=sy9E88J8; dkim=pass header.d=quip.cz header.s=private header.b=Wy7oeP6X; dmarc=none; spf=none (mx1.freebsd.org: domain of "SRS0=mZYy=4G=quip.cz=000.fbsd@elsa.codelab.cz" has no SPF policy when checking 94.124.105.4) smtp.mailfrom="SRS0=mZYy=4G=quip.cz=000.fbsd@elsa.codelab.cz" Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 82A11D788C; Sat, 27 Sep 2025 12:48:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1758970096; bh=+RCDHOakYN3HwqwE0sVWaltapmMUVcBBz4exgyubOOw=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=sy9E88J84rVTMo5shOJzg2lxnr/qMe3MyTZb1CQaPs8kRfIkp/AOBWvpmq2FqM/+g Eb1b1yBQKdI7hxK4zSGsZdt4C6uhUMsfAKTSnUeSLnKso+ngPT0fnZr7vkUqgQEBuZ UFeWB/5keDWu2YHq0/E+iO0zljGsaZfVyztamdDQ= Received: from [192.168.145.49] (ip-89-177-27-225.bb.vodafone.cz [89.177.27.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id E3394D788A; Sat, 27 Sep 2025 12:48:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1758970095; bh=+RCDHOakYN3HwqwE0sVWaltapmMUVcBBz4exgyubOOw=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Wy7oeP6XGxhHG0lAT36/FhKvkOMsiOqh1oMjy1ATm0uo7qqBcoAYmA9wh2tYXQEMq cyjxt6KyiBK74oEaXFP6sr5grMRvxixOITzDbx9Bg8wfNRK293HfD+TRmWi7ojEJJi H9T93poYgSHC0VrDAvuUCrRksWNEoIbLuw9IPnsY= Message-ID: Date: Sat, 27 Sep 2025 12:48:13 +0200 List-Id: Discussion related to /etc/rc.d design and implementation List-Archive: https://lists.freebsd.org/archives/freebsd-rc List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-rc@freebsd.org Sender: owner-freebsd-rc@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Adding some consistency to /etc/rc.d/* To: Jamie Landeg-Jones , freebsd@gushi.org Cc: crees@freebsd.org, freebsd-rc@freebsd.org References: <5A421FFF-9DE4-4CBF-8914-B85CFEEEEDB3@gushi.org> <6FA9B378-7E60-41CA-8947-CF3CA519468F@gushi.org> <202509072159.587Lxjmw001260@donotpassgo.dyslexicfish.net> Content-Language: en-US From: Miroslav Lachman <000.fbsd@quip.cz> In-Reply-To: <202509072159.587Lxjmw001260@donotpassgo.dyslexicfish.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FORGED_SENDER(0.30)[000.fbsd@quip.cz,SRS0=mZYy=4G=quip.cz=000.fbsd@elsa.codelab.cz]; R_DKIM_ALLOW(-0.20)[quip.cz:s=private]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_NA(0.00)[no SPF record]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[quip.cz]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-rc@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[000.fbsd@quip.cz,SRS0=mZYy=4G=quip.cz=000.fbsd@elsa.codelab.cz]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[quip.cz:+] X-Rspamd-Queue-Id: 4cYkh939wfz3WrV On 07/09/2025 23:59, Jamie Landeg-Jones wrote: > "Dan Mahoney (Ports)" wrote: > >> Here was a pull request for ntpd. It mostly involved removing quotes from variable names, formatting functions consistently, and reordering a few functions at the top: https://github.com/freebsd/freebsd-src/compare/main...thegushi:freebsd-src:rclint-ntpd > > Do we actually have any style convention applicable here? > > I personally prefer to quote strings, even though I know exactly where and when they are needed. > > I like the idea of this program, but in the case of quoting, the above linked result looks worse in my opinion. > > I know it's not authorative, but googles style guide agrees: https://google.github.io/styleguide/shellguide.html Unquoted strings seems strange to me too. Few lines without quotes followed by one line with quotes then another line without quotes... I think it does not help anything / anybody. If I can vote, I vote for quoted strings. (and the diff will be smaller) Kind regards Miroslav Lachman