[Bug 279200] sysrc(8) fails to perform set operations for += and -= in -c (check only) mode.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 28 Apr 2025 18:21:55 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279200
--- Comment #3 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=c97460c4d97db1bd46dab9f2bdbc90cd1ed7757f
commit c97460c4d97db1bd46dab9f2bdbc90cd1ed7757f
Author: Michal Scigocki <michal.os@hotmail.com>
AuthorDate: 2025-04-14 07:01:06 +0000
Commit: Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-04-28 18:18:08 +0000
sysrc: Fix check flag logic for append and subtract
When using sysrc with the check flag (-c), the append (+=) and subtract
(-=) operations result in incorrect return values because on the check
path the necessary union/difference calculation logic is not performed.
However, the correct union/difference calculation is already performed
when running without the check flag. We fix the issue on the check path
by using the results from the existing union/difference calculation in
the check logic to get the correct return values.
PR: 279200
Reviewed by: markj
MFC after: 1 month
Pull Request: https://github.com/freebsd/freebsd-src/pull/1664
usr.sbin/sysrc/sysrc | 52 +++++++++++++++++++++++++---------------------------
1 file changed, 25 insertions(+), 27 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.