From nobody Mon Apr 28 18:21:55 2025 X-Original-To: rc@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZmWxc5QkBz5thbJ for ; Mon, 28 Apr 2025 18:21:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZmWxc1GWwz3Znl for ; Mon, 28 Apr 2025 18:21:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745864516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mZ3h2jS0qM0QRBC7eHd7nFwxEerd8qOC/VHLmQcO80Q=; b=sngnGg/Zlz2R3l/NL1O1xZLAz/78MGOEAAqEC+pm/QerXTZSlNtXOtPLyGHmT90Kq6m81i E2sxZxyjrePtSbef+lt8L0A0UOnUUl3jskvbAvdIUe8TYc6hFnnXTXMcIvQLUmYgh5Z9dy IQ5iL4qtereAsdprtXRIZKnHyXfwqW5N5p5sF5uVDAPJ7kWYJaeDV0L/FJGLMX4Zr5OQZ4 7vILa5EJyuxshHY0L4kCA+YudKEDZYtBOv7vVJsXDdxmY1MPeuJLFW5YsqmduL5iIl8qqF 5tNQ1piGtuQG6UlEWSvC8h7cTaM/MBPswjytr1J4PH7axRCDD/hDNk71QkZBEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745864516; a=rsa-sha256; cv=none; b=K1rBXKcbbM8GhxsOcxQaqJSnnVoDB+2+iGHXqkhhkn984/I4X2+GXY5jUrlZ5AEua2Mi+e yI/t1jOg1lAxbfTkPsKomfDRbjRoUiwscXEEl6BJ2UUxM4nsW9DMZeU2gEo+dBARTEcpcC 0U+IlT0XxH16eWeou/vuqc49f0HYufBEa/nTQukYsK24Xp+1UjWE1TqgI9EtD8nEDPEX5C hWdpPGmCOCfHCFQ7TxKpA00oTZ4UGIPPc2gruO8b6NCcsQV3nXvsVt0dG0MGk3lay1AD0K uqeUfl9Td3BVzDhPPCJ0Sk2Yal2t8RzuK9zsQRR2gvIA/hBDVLYSnxi+mBrJlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745864516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mZ3h2jS0qM0QRBC7eHd7nFwxEerd8qOC/VHLmQcO80Q=; b=uHKD1kW6afKwdfA2/N8mFUa5BDhxkbl+dzUgzK2BFyDNwfFei46xu5kq+RzZZX9bZp4hyF ojrENIHXdU733cSZUuLQfYU7qvKvBSBfqGUBbZs4CMtbenp5guGKyE6YUm97u9XWqarY6p 5cwrn63/4BJEWzcHJ6iZ6oDbsrqLdWNAGFyEeUIZ5ZQMsJMi8Dwa6SGFr3kc67KyJWvk/y gkb9RFsjL1hiU/aZDYzMCJIBFJkdUmWIFSHxKHJWgfHpzT2r69bfr4RqlNTmUKoYggmSMs gQBGpVabdLZp3hXNp1uz4LKl6Xda0UK36t6RhPkdWjjy2cs68QLsSN5MLVvfgg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZmWxc0r8yzlt4 for ; Mon, 28 Apr 2025 18:21:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 53SILuFr057385 for ; Mon, 28 Apr 2025 18:21:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 53SILtGE057384 for rc@FreeBSD.org; Mon, 28 Apr 2025 18:21:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: rc@FreeBSD.org Subject: [Bug 279200] sysrc(8) fails to perform set operations for += and -= in -c (check only) mode. Date: Mon, 28 Apr 2025 18:21:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion related to /etc/rc.d design and implementation List-Archive: https://lists.freebsd.org/archives/freebsd-rc List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-rc@freebsd.org Sender: owner-freebsd-rc@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279200 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc97460c4d97db1bd46dab9f2bdbc90cd1= ed7757f commit c97460c4d97db1bd46dab9f2bdbc90cd1ed7757f Author: Michal Scigocki AuthorDate: 2025-04-14 07:01:06 +0000 Commit: Mark Johnston CommitDate: 2025-04-28 18:18:08 +0000 sysrc: Fix check flag logic for append and subtract When using sysrc with the check flag (-c), the append (+=3D) and subtra= ct (-=3D) operations result in incorrect return values because on the check path the necessary union/difference calculation logic is not performed. However, the correct union/difference calculation is already performed when running without the check flag. We fix the issue on the check path by using the results from the existing union/difference calculation in the check logic to get the correct return values. PR: 279200 Reviewed by: markj MFC after: 1 month Pull Request: https://github.com/freebsd/freebsd-src/pull/1664 usr.sbin/sysrc/sysrc | 52 +++++++++++++++++++++++++-----------------------= ---- 1 file changed, 25 insertions(+), 27 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=