[Bug 269566] New port: lang/mlkit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269566

Daniel Engberg <diizzy@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |diizzy@FreeBSD.org

--- Comment #7 from Daniel Engberg <diizzy@FreeBSD.org> ---
Hi,

Looks good overall, you don't need to wrap TEST_TARGET and as Robert mentioned
if "make test" doesn't "need" any functionality from the framework you don't
need to make it an option.

While cosmetic you possibly want to push version data to the build, preferably
so it's reproducable looking at
https://github.com/melsman/mlkit/blob/master/configure.ac#L48 . These variables
might also be used to generate version data in the binaries. In general we
don't want to depend on git for building.

While I guess it's preference USES= shebangfix uses full path so I think it's
fine for consistency however it should use LOCALBASE and not PREFIX.

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.