From nobody Sat May 20 22:35:42 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QNz7f3JqFz4BcyF for ; Sat, 20 May 2023 22:35:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QNz7f1p0vz4LKJ for ; Sat, 20 May 2023 22:35:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684622142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2VtkZ11o2806Vk+xSLaZgDY9JwbUXIS7iotFEW3xoxM=; b=j9thznZSk17JttYrdiRq60aQdBREKXJBJO1j5jrYGSx0aMkPD35pN32SntjCuKpN4pURYu +h8dYe/GO+aKEk+bRwGz7Dk2diZLm1e50YB4LzOT1/p80bLfiq3L667B/16JLU1OXQDg80 jlW/+EPIi7x8XLzG5zx4cr/kLY1xM+0owkqjkfAD75hpKw3myVA2RWNgtLtfguB6O1rFfn 5XGtwACqhGShTiAIDU3TqFXSi6TjXGif0utvdS2hV2xgH+ficUhPXG2mjEtwCihBNBP+YR LzGVJO7e8rUBk4YQmjJtojvYI3A03nc9FUt2vKyZAOXcNHujS5gLjHJNMClZ1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684622142; a=rsa-sha256; cv=none; b=WEO07o9yGRoNZoGFZvX/CpBcw4GS+tBllGuSV3iN0FHs9T6KERj7MBYUGVjupvLaEquNX2 6avygoSAHQhHSC+m4ZfcN53oyqgE+m1G2B/bID+ENP9opKm54UOnR+OLQSiSlrMU2ad0Um IMtgDnQObdEqdlMj1rZ2nB01SXBJ+0Aoo96oLD7/88UD5rlc3DXFPg12pNh/0IJi2PY8ht FT7V6WO85wT8/1SvHYQ5QFVRfBVgZtja8By01zVU0raCmKhT1Hvnu2Tkqqy1v5vxH8t0xt afwYqo3h62PEJHWJoaQ0q7cp+6ZEdumFp2REU3rKHZdbXrc2wI+KeGEOe6wRLA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QNz7f0lJgzS9C for ; Sat, 20 May 2023 22:35:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34KMZgRE062714 for ; Sat, 20 May 2023 22:35:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34KMZg8K062713 for ports-bugs@FreeBSD.org; Sat, 20 May 2023 22:35:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269566] New port: lang/mlkit Date: Sat, 20 May 2023 22:35:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: diizzy@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269566 Daniel Engberg changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |diizzy@FreeBSD.org --- Comment #7 from Daniel Engberg --- Hi, Looks good overall, you don't need to wrap TEST_TARGET and as Robert mentio= ned if "make test" doesn't "need" any functionality from the framework you don't need to make it an option. While cosmetic you possibly want to push version data to the build, prefera= bly so it's reproducable looking at https://github.com/melsman/mlkit/blob/master/configure.ac#L48 . These varia= bles might also be used to generate version data in the binaries. In general we don't want to depend on git for building. While I guess it's preference USES=3D shebangfix uses full path so I think = it's fine for consistency however it should use LOCALBASE and not PREFIX. Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=