[Bug 271190] mail/mutt: bug in quote patch

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271190

--- Comment #9 from Kurt Hackenberg <kh@panix.com> ---
Optional or not, the bug I reported is unacceptable. It uses
text_plain_handler(), the function for format=fixed, to handle quoting of
messages that are text/plain format=flowed. That's a crude hack, blatantly
wrong, destructive. It may cause more problems than the two I've noticed.

That hack was probably done to apply the patch's quoting features to flowed
text as well as fixed, and that idea is wrong. For flowed text, the quoting
mechanism is defined by RFC 3676, and may not be changed. As it is now, the
patch could generated quoted text that will not be understood by other mail
readers.

The patch should be either repaired or dropped.

The patch adds two optional small features that modify the string of '>' and
space used to quote a message in a reply. It does not add those features to the
Mutt documentation, so they're probably not widely known. I use Mutt, and
didn't know those features existed. I found all this by debugging a symptom.

Also, I agree with Derek that it's best to hold down the number of patches.

I say, drop the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.