[Bug 271190] mail/mutt: bug in quote patch

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271190

            Bug ID: 271190
           Summary: mail/mutt: bug in quote patch
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: kh@panix.com
                CC: dereks@lifeofadishwasher.com
             Flags: maintainer-feedback?(dereks@lifeofadishwasher.com)
                CC: dereks@lifeofadishwasher.com

The quote patch includes this change to mutt_body_handler(), in handler.c:

-      else if (option(OPTREFLOWTEXT) && ascii_strcasecmp ("flowed",
mutt_get_parameter ("format", b->parameter)) == 0)
+      else if (option(OPTREFLOWTEXT) && ascii_strcasecmp ("flowed",
mutt_get_parameter ("format", b->parameter)) == 0 && !s->prefix)

That's wrong. That line should not be modified; the extra condition "&&
!s->prefix" should not be added. It's clearly wrong just from reading code, and
it causes two symptoms that I know of.

Excising that wrongly added condition fixes the two symptoms.

Ideally, the author of that patch would fix it. Otherwise, the FreeBSD port
could patch the patch or not use the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.