[Bug 271156] graphics/imlib2: Fix X11 dependency (third time)

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 01 May 2023 11:40:38 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271156

--- Comment #2 from fsbruva@yahoo.com ---
(In reply to Mina Galić from comment #1)
Good point. The issue is not during imlib2 build, as the ports Makefile
correctly passes --without-x to configure, and all is well.

The problem is that the unmodified Imlib2.h gets installed to
${LOCALBASE}/include. Dependent programs that #include Imlib2.h need to ALSO
set X_DISPLAY_MISSING, but may not know they need to. Within Imlib2.h, there
are numerous function prototypes that are also protected by #ifndef
X_DISPLAY_MISSING, because when imlib2 was build built, the --without-x
influenced the build.

My thought is that once the Imlib2.h is installed, it should reflect the
library as installed. To this end, defining X_DISPLAY_MISSING seemed like the
easiest and simplest method to ensure success for dependent ports.

-- 
You are receiving this mail because:
You are the assignee for the bug.