[Bug 271156] graphics/imlib2: Fix X11 dependency (third time)

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 01 May 2023 03:08:01 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271156

            Bug ID: 271156
           Summary: graphics/imlib2: Fix X11 dependency (third time)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: fsbruva@yahoo.com

Created attachment 241892
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=241892&action=edit
Patch to fix X11 dependency

When imlib2 is built without support for X11, Imlib2.h #includes X11/Xlib.h
conditionally, guarded by an #ifndef X_DISPLAY_MISSING – X_DISPLAY_MISSING,
however, isn't set, causing Imlib2.h to unsuccessfully include the header. This
was previously addressed in bug #187147 by patching Imlib2.h, then again in bug
#224354. However, 44242130fc9df45a4ef5d96dbb6b1c75b6a14123 removed the
REINPLACE_CMD. 

When X11 is unset, imlib2 builds and installs correctly, but the Imlib2.h
header has the same above described problem with X_DISPLAY_MISSING being
undefined. This causes problems when building dependent ports, such as libcaca.
The error manifests during build.

In file included from ../src/common-image.c:21:
/usr/local/include/Imlib2.h:26:10: fatal error: 'X11/Xlib.h' file not found
#include <X11/Xlib.h>
         ^~~~~~~~~~~~
1 error generated.
*** Error code 1

Stop.
make[3]: stopped in
/wrkdirs/usr/ports/graphics/libcaca/work/libcaca-0.99.beta19/examples
*** Error code 1

This patch defines X_DISPLAY_MISSING within Imlib2.h when X11 is unset.

-- 
You are receiving this mail because:
You are the assignee for the bug.