[Bug 264475] [NEW PORT] security/openca -ocspd : OpenCA’s OCSP responder

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 06 Jun 2022 08:22:53 UTC

Daniel Engberg <diizzy@FreeBSD.org> changed:

           What    |Removed                     |Added
                 CC|                            |diizzy@FreeBSD.org

--- Comment #1 from Daniel Engberg <diizzy@FreeBSD.org> ---

Thanks for your patch! Looks good overall but there are some parts that looks a
bit strange (quick review)

L6: DISTVERSIONPREFIX should be defined before DISTVERSION
Ref: "Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX" in Porters Handbook

L13: Please also define LICENSE_FILE

L21: Remove

L31: Shouldn't be needed, if so please fix patches

openca-ocspd/files/patch-global-vars.in - Is this patch correct?

L2, L3: This is a bit hacky, just remove the files in ports Makefile and/or
project Makefile(s)

Tested on (version, arch)? Does it build using Poudriere?

Please also try to submit changes to upstream

Best regards,

You are receiving this mail because:
You are the assignee for the bug.