[Bug 264475] [NEW PORT] security/openca -ocspd : OpenCA’s OCSP responder

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264475

Daniel Engberg <diizzy@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |diizzy@FreeBSD.org

--- Comment #1 from Daniel Engberg <diizzy@FreeBSD.org> ---
Hi,

Thanks for your patch! Looks good overall but there are some parts that looks a
bit strange (quick review)

security/openca-ocspd/Makefile
L6: DISTVERSIONPREFIX should be defined before DISTVERSION
Ref: "Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX" in Porters Handbook

L13: Please also define LICENSE_FILE

L21: Remove

L31: Shouldn't be needed, if so please fix patches

openca-ocspd/files/patch-global-vars.in - Is this patch correct?

security/openca-ocspd/pkg-plist
L2, L3: This is a bit hacky, just remove the files in ports Makefile and/or
project Makefile(s)

Tested on (version, arch)? Does it build using Poudriere?

Please also try to submit changes to upstream

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.