From nobody Mon Jun 06 08:22:53 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B24451BE5364 for ; Mon, 6 Jun 2022 08:22:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LGmhF68qsz4Vwg for ; Mon, 6 Jun 2022 08:22:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A055C22876 for ; Mon, 6 Jun 2022 08:22:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2568MraW000351 for ; Mon, 6 Jun 2022 08:22:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2568Mrdk000350 for ports-bugs@FreeBSD.org; Mon, 6 Jun 2022 08:22:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: =?UTF-8?B?W0J1ZyAyNjQ0NzVdIFtORVcgUE9SVF0gc2VjdXJpdHkvb3BlbmNh?= =?UTF-8?B?LW9jc3BkIDogT3BlbkNB4oCZcyBPQ1NQIHJlc3BvbmRlcg==?= Date: Mon, 06 Jun 2022 08:22:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: diizzy@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654503774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PYkKPAZex3g7F52/07nMWWuOuD54OkykjC6Up7+Z3Ew=; b=CS0LzUOnE/HX8WNoZE2wzcEC8B8DlCoGAVDHdLFdN1itWX6yah6FoeziFERKLaa5nWtwcG d4FfiCxZP5GFnrnxDVbOVY965M1lAAm66zhzSvG+QiOwJyMcFvEmrNH8CfPCi9CNO0m5YZ qsTmmPQzuaYz0RtTya3iAxFohSkbc4HGvIFao6R0COCvw7etLqLq0qXvJI7q9UQJLmLSF+ N8oEYY47GXJV9Nw2fm2cTJ2xyfqgi3vwoiHcdi/V9sBWT3jVN+DS4+4aXyXBu8+f8qGaqb 0gQqrcxiY0CYaK+x7b0WN0Xa38NJQPZckJw27spzJcd6l0lf5VoG6YXuWdFBGA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654503774; a=rsa-sha256; cv=none; b=NXtbSOkR5sn0+TgrNhkMPFpl1MH4x23GUQVUVLA9vQLOyNfcUrAGmk5o9vlNDjJf1v5sr+ HlFsFK9ovNRYEaOhrw8om0aPqPL4dWwsdC5Efrtu+3TW7QQlgA8y8IeObKqJoy4cNS+ntt y+I6zxQPa30ijmL0N0BXsK62Kz6fZqh/5ar2EBSbFJA1Z1P1yhys3De4Nt1Nif8YRiW2OO 2eJ6fs0bID8ykiCtIlC9dL5Cl1XSCGDylbEELD5HOw1Tbh6ibbHz+INX1IfFvJUym9XY0j QbOf75VaCITpxjgzghZlFpeibViIAlN0kYKszCJykPuBW5eiYOfRO0ntWhNa5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264475 Daniel Engberg changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |diizzy@FreeBSD.org --- Comment #1 from Daniel Engberg --- Hi, Thanks for your patch! Looks good overall but there are some parts that loo= ks a bit strange (quick review) security/openca-ocspd/Makefile L6: DISTVERSIONPREFIX should be defined before DISTVERSION Ref: "Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX" in Porters Hand= book L13: Please also define LICENSE_FILE L21: Remove L31: Shouldn't be needed, if so please fix patches openca-ocspd/files/patch-global-vars.in - Is this patch correct? security/openca-ocspd/pkg-plist L2, L3: This is a bit hacky, just remove the files in ports Makefile and/or project Makefile(s) Tested on (version, arch)? Does it build using Poudriere? Please also try to submit changes to upstream Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=