[Bug 261891] [NEW PORT] graphics/epsonscan2: scanner engine supporting many Seiko/Epson scanners

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261891

Daniel Engberg <diizzy@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |diizzy@FreeBSD.org

--- Comment #21 from Daniel Engberg <diizzy@FreeBSD.org> ---
A few suggestions and questions for graphics/epsonscan2

While there's nothing wrong Porters Handbook recommends you to use DISTVERSION
unless the framework can't determine version on its own.

Ref: "3.1. Writing the Makefile" and "Table 2. Package Naming Examples"
https://docs.freebsd.org/en/books/porters-handbook/book/

Please define LICENSE_FILE
Reference:
https://docs.freebsd.org/en/books/porters-handbook/makefiles/index.html#licenses-license_file

Is it correct what we need both pcre and pcre2?

Please define gettext-runtime dependency via USES=
https://cgit.freebsd.org/ports/tree/Mk/Uses/gettext-runtime.mk
Ref:
https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-gettext-runtime

Please define glib dependency using USES and USE_GNOME
Example: https://cgit.freebsd.org/ports/tree/irc/irssi/Makefile#n14
Reference: https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-gnome

USES= for JPEG --> https://cgit.freebsd.org/ports/tree/Mk/Uses/jpeg.mk
Not sure why it's missing in Porters Handbook

CFLAGS --> USES= localbase
https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-localbase
Ref: https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk

LDFLAGS should probably be added?
"6.3. Shared Libraries" in Porters Handbook

%%DOCSDIR%%-1.0.0.0-1/ looks like a strange path

Great work!

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.