From nobody Wed Feb 16 18:45:02 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 54EE619D1FF6 for ; Wed, 16 Feb 2022 18:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JzRht1DHxz4rjs for ; Wed, 16 Feb 2022 18:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 07E4F1B4D3 for ; Wed, 16 Feb 2022 18:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21GIj1qd002894 for ; Wed, 16 Feb 2022 18:45:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21GIj19S002893 for ports-bugs@FreeBSD.org; Wed, 16 Feb 2022 18:45:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261891] [NEW PORT] graphics/epsonscan2: scanner engine supporting many Seiko/Epson scanners Date: Wed, 16 Feb 2022 18:45:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: diizzy@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645037102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQArEi4m+W5rQOakKmfICMt5fPJj3E8NefLdFkj3gLE=; b=Bb/f0DYuECGWGCAe+JZ+Ej8CTS3clMi0DRe/yDoxeBgjfeSQf/q5ey4/aAetalA+yaIWvn nKnFBhYz3xwgb5Q4gec13//MQbLlNSY2QmTXy5vYoWxGdXk3RXXp2ckX0Jq3obu+1HvpHZ 0sWsWOpwmXdq0Lni9I+gT5GxAqJHn++mTHwaAWB0tRYjFS5ZXWRfHDsI6nHADNbqDgjrg4 SGroOkcSt7iAxItXMG7KDM1wfPPYNAo2A4+lys5o+KiCeaHds2tyLT5azDPPvZxHOupE6Z MIYAhEzusY3gv/rvbD0KUjn5AYUyOhN0HZzsL8qmqOJBiML5tKgLvJV5JSlc2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645037102; a=rsa-sha256; cv=none; b=p3rrgFNnD61S2vCc5lpCr4vyFYRhsrDLamIgdPhZic3/6Eoo9zzLZ5PHL+cABi8DKopk7D sP4kdNXmiAVzB3D2WC9ff/8brTbHLrE0Opq20xb3mHZKErGckRJvaB2RBM7YtPAwHKj2Db D3XX9c314TvWwhR/VIwOhUf4bFJ2nMl3GhOcxRISIUsmMt6DBlsq7jfkf9zyLbo82Es0Gf xriPa+IJREfZlno/HTs3FGTvBUNDK8rTweHdfXNpnQHcuyDFPYmp7+Z5vZQydax+Nuwhmq H9xB/aAyaUYE0BRnOvvUsTCyY5dE1M778j2LHrO/mEYP5duAb3tWD3hG0DOqrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261891 Daniel Engberg changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |diizzy@FreeBSD.org --- Comment #21 from Daniel Engberg --- A few suggestions and questions for graphics/epsonscan2 While there's nothing wrong Porters Handbook recommends you to use DISTVERS= ION unless the framework can't determine version on its own. Ref: "3.1. Writing the Makefile" and "Table 2. Package Naming Examples" https://docs.freebsd.org/en/books/porters-handbook/book/ Please define LICENSE_FILE Reference: https://docs.freebsd.org/en/books/porters-handbook/makefiles/index.html#lic= enses-license_file Is it correct what we need both pcre and pcre2? Please define gettext-runtime dependency via USES=3D https://cgit.freebsd.org/ports/tree/Mk/Uses/gettext-runtime.mk Ref: https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-gettext-runti= me Please define glib dependency using USES and USE_GNOME Example: https://cgit.freebsd.org/ports/tree/irc/irssi/Makefile#n14 Reference: https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-gn= ome USES=3D for JPEG --> https://cgit.freebsd.org/ports/tree/Mk/Uses/jpeg.mk Not sure why it's missing in Porters Handbook CFLAGS --> USES=3D localbase https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-localbase Ref: https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk LDFLAGS should probably be added? "6.3. Shared Libraries" in Porters Handbook %%DOCSDIR%%-1.0.0.0-1/ looks like a strange path Great work! Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=