[Bug 256221] dns/knot-resolver: the kresd init script won't stop the service

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 22 Jun 2021 13:34:03 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256221

--- Comment #22 from Leo Vandewoestijne <freebsd_at_dns.company> ---
Created attachment 225993
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225993&action=edit
knot-resolver fixes and cleanup

`daemon` seems needed as otherwise I can't get it to background,
at least not in a way that I think is decent.

About the most recent patch:

- The printf in the 'for pid loop' was inside the loop, being a bit too
verbose.

- The install of the possible missing var dir was inside the if/elif/else loop;
 and then start still would fail in that particular case.

- I simplified the restart routine but then discovered it all was identical to
what was inside start/stop already, and so I don't think a restart routine is
needed (as restart will work without having a custom one defined).

- I do share the thoughts about using "ps | grep | etc" for finding pid's.
And do share the view something is better than nothing.

poudriere complained about _at_sample / .sample
Fixed.

portfmt complained about all sorts of minor things.
Fixed a few.

IMHO this patch should be fine, but gladly welcome any major or nitpick
comments.

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Tue Jun 22 2021 - 13:34:03 UTC

Original text of this message