From nobody Tue Jun 22 13:34:03 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1675A11D31F5 for ; Tue, 22 Jun 2021 13:34:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G8S6M03Kxz4hYD for ; Tue, 22 Jun 2021 13:34:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DEA2511F28 for ; Tue, 22 Jun 2021 13:34:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 15MDY2qn076238 for ; Tue, 22 Jun 2021 13:34:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 15MDY2M0076237 for ports-bugs@FreeBSD.org; Tue, 22 Jun 2021 13:34:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256221] dns/knot-resolver: the kresd init script won't stop the service Date: Tue, 22 Jun 2021 13:34:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: freebsd@dns.company X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256221 --- Comment #22 from Leo Vandewoestijne --- Created attachment 225993 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225993&action= =3Dedit knot-resolver fixes and cleanup `daemon` seems needed as otherwise I can't get it to background, at least not in a way that I think is decent. About the most recent patch: - The printf in the 'for pid loop' was inside the loop, being a bit too verbose. - The install of the possible missing var dir was inside the if/elif/else l= oop; and then start still would fail in that particular case. - I simplified the restart routine but then discovered it all was identical= to what was inside start/stop already, and so I don't think a restart routine = is needed (as restart will work without having a custom one defined). - I do share the thoughts about using "ps | grep | etc" for finding pid's. And do share the view something is better than nothing. poudriere complained about @sample / .sample Fixed. portfmt complained about all sorts of minor things. Fixed a few. IMHO this patch should be fine, but gladly welcome any major or nitpick comments. --=20 You are receiving this mail because: You are the assignee for the bug.=