[Bug 256407] 'make check-plist' doesn't complain when optional file is installed despite the option being 'off'
Date: Fri, 04 Jun 2021 08:31:26 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256407 Bug ID: 256407 Summary: 'make check-plist' doesn't complain when optional file is installed despite the option being 'off' Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: yuri@freebsd.org CC: ports-bugs@FreeBSD.org Created attachment 225538 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225538&action=edit testcase.shar The attached testcase installs the file bin/xz unconditionally, while pkg-plist has it conditional on the option Z (%%Z%%bin/xz). With Z=OFF 'make check-plist' doesn't complain as it should that bin/xz is missing from pkg-plist: > ====> Checking for pkg-plist issues (check-plist) > ===> Parsing plist > ===> Checking for items in STAGEDIR missing from pkg-plist > ===> Checking for items in pkg-plist which are not in STAGEDIR > ===> No pkg-plist issues found (check-plist) Porter's Handbook says: > In pkg-plist, put %%X11%% in front of the lines only being installed when the option is enabled, like this: > > %%X11%%bin/foo-gui -- You are receiving this mail because: You are on the CC list for the bug.