From nobody Fri Jun 04 08:31:26 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5D882137DCA6 for ; Fri, 4 Jun 2021 08:31:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FxGFV24njz4YV7 for ; Fri, 4 Jun 2021 08:31:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2F83A19C2B for ; Fri, 4 Jun 2021 08:31:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1548VQBK039597 for ; Fri, 4 Jun 2021 08:31:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1548VQ29039596 for ports-bugs@FreeBSD.org; Fri, 4 Jun 2021 08:31:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256407] 'make check-plist' doesn't complain when optional file is installed despite the option being 'off' Date: Fri, 04 Jun 2021 08:31:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yuri@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256407 Bug ID: 256407 Summary: 'make check-plist' doesn't complain when optional file is installed despite the option being 'off' Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: yuri@freebsd.org CC: ports-bugs@FreeBSD.org Created attachment 225538 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225538&action= =3Dedit testcase.shar The attached testcase installs the file bin/xz unconditionally, while pkg-p= list has it conditional on the option Z (%%Z%%bin/xz). With Z=3DOFF 'make check-plist' doesn't complain as it should that bin/xz is missing from pkg-plist: > =3D=3D=3D=3D> Checking for pkg-plist issues (check-plist) > =3D=3D=3D> Parsing plist > =3D=3D=3D> Checking for items in STAGEDIR missing from pkg-plist > =3D=3D=3D> Checking for items in pkg-plist which are not in STAGEDIR > =3D=3D=3D> No pkg-plist issues found (check-plist) Porter's Handbook says: > In pkg-plist, put %%X11%% in front of the lines only being installed when= the option is enabled, like this: > > %%X11%%bin/foo-gui --=20 You are receiving this mail because: You are on the CC list for the bug.=