[Bug 257910] security/p5-IO-Socket-SSL: Update to 2.072

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 17 Aug 2021 12:43:42 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257910

Nuno Teixeira <eduardo_at_FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eduardo_at_FreeBSD.org

--- Comment #1 from Nuno Teixeira <eduardo_at_FreeBSD.org> ---
Created attachment 227281
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=227281&action=edit
"git diff" to update the port reformated

Hello,

I'm thinking that this port could have some small fixes and formating:

1. Use DISTVERSION instead of PORTVERSION:
---
Example 2. Using DISTVERSION

When the version only contains numbers separated by dots, dashes or
underscores, use DISTVERSION.

https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-naming
---

2. Alphatical order in RUN_DEPENDS:
---
-RUN_DEPENDS=   p5-Net-SSLeay>=1.59:security/p5-Net-SSLeay \
-               p5-Mozilla-CA>=20130114:www/p5-Mozilla-CA
+RUN_DEPENDS=   p5-Mozilla-CA>=20130114:www/p5-Mozilla-CA \
+               p5-Net-SSLeay>=1.59:security/p5-Net-SSLeay
---
with p5-'M'ozilla-CA first and p5-'N'et-SSLeay next

3. Add and extra tab in +OPTIONS_DEFINE so it can be aligned with variables
bellow:
---
-OPTIONS_DEFINE=        EXAMPLES IDN IPV6
+OPTIONS_DEFINE=                EXAMPLES IDN IPV6
---

I've used portfmt tool to check Makefile formating but sometimes it could lead
to mistakes. With this port I think it worked fine.

Please check my patch and tell me if it is ok.

Thanks

3. Add an extra tab

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Tue Aug 17 2021 - 12:43:42 UTC

Original text of this message