From nobody Tue Aug 17 12:43:42 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 616FC176517B for ; Tue, 17 Aug 2021 12:43:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GprLQ1KHDz4kt4 for ; Tue, 17 Aug 2021 12:43:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 153CC1DE9D for ; Tue, 17 Aug 2021 12:43:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 17HChga8055055 for ; Tue, 17 Aug 2021 12:43:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 17HChgjM055054 for ports-bugs@FreeBSD.org; Tue, 17 Aug 2021 12:43:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 257910] security/p5-IO-Socket-SSL: Update to 2.072 Date: Tue, 17 Aug 2021 12:43:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eduardo@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257910 Nuno Teixeira changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eduardo@FreeBSD.org --- Comment #1 from Nuno Teixeira --- Created attachment 227281 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D227281&action= =3Dedit "git diff" to update the port reformated Hello, I'm thinking that this port could have some small fixes and formating: 1. Use DISTVERSION instead of PORTVERSION: --- Example 2. Using DISTVERSION When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION. https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-nami= ng --- 2. Alphatical order in RUN_DEPENDS: --- -RUN_DEPENDS=3D p5-Net-SSLeay>=3D1.59:security/p5-Net-SSLeay \ - p5-Mozilla-CA>=3D20130114:www/p5-Mozilla-CA +RUN_DEPENDS=3D p5-Mozilla-CA>=3D20130114:www/p5-Mozilla-CA \ + p5-Net-SSLeay>=3D1.59:security/p5-Net-SSLeay --- with p5-'M'ozilla-CA first and p5-'N'et-SSLeay next 3. Add and extra tab in +OPTIONS_DEFINE so it can be aligned with variables bellow: --- -OPTIONS_DEFINE=3D EXAMPLES IDN IPV6 +OPTIONS_DEFINE=3D EXAMPLES IDN IPV6 --- I've used portfmt tool to check Makefile formating but sometimes it could l= ead to mistakes. With this port I think it worked fine. Please check my patch and tell me if it is ok. Thanks 3. Add an extra tab --=20 You are receiving this mail because: You are the assignee for the bug.=