Re: An odd vital FreeBSD-set-* result?

On Fri, 19 Sep 2025 18:32:18 +0100
Lexi Winter <ivy@freebsd.org> wrote:

> Mark Millard wrote in <D00275AE-2E13-45AC-AAF4-D5410E07553E@yahoo.com>:
> > But the following indicates that the cached *.pkg files themselves
> > agree with the just-4-vitals status:
> 
> do you build your packages with "make update-packages"?  if so, can you
> try deleting your ${REPODIR} and rebuilding, so all packages are
> recreated?
> 
> i'm wondering if adding the vital flag (but not changing anything else)
> doesn't cause update-packages to actually update the package.

 Vital flag isn't taken into account for calculating the internal
checksum (See
https://github.com/freebsd/pkg/blob/main/libpkg/pkg_checksum.c#L197) we
should probably add it there.

 Cheers,

> > Also of note is the lack of a new-line between the prior } and the
> > name: for most of the above. An example of a surrounding context is:
> > 
> > categories: [
> >     "base"
> > ]
> > annotations: {
> >     FreeBSD_version: "1600000"
> > }name: "FreeBSD-set-base-dbg"
> > origin: "base"
> 
> it looks the UCL output from 'pkg info' doesn't have a trailing newline.
> i think this is a pkg(8) bug, but it shouldn't have anything to do with
> this issue.
> 
> to confirm, this is the full output i get for the set-src package, using
> 'echo' to force a trailing newline:
> 
> # pkg info -R -F /build/packages/base/FreeBSD:16:amd64/latest/FreeBSD-set-src-16.snap20250919160159.pkg; echo
> name: "FreeBSD-set-src"
> origin: "base"
> version: "16.snap20250919160159"
> comment: "System source code"
> maintainer: "re@FreeBSD.org"
> www: "https://www.FreeBSD.org"
> abi: "FreeBSD:16:amd64"
> arch: "freebsd:16:x86:64"
> prefix: "/"
> flatsize: 0
> licenselogic: "single"
> licenses: [
>     "BSD2CLAUSE"
> ]
> vital: true
> desc: "This metapackage installs source code for the base system and kernel."
> deps: {
>     FreeBSD-src: {
>         origin: "base",
>         version: "16.snap20250919160159"
>     },
>     FreeBSD-src-sys: {
>         origin: "base",
>         version: "16.snap20250919160159"
>     }
> }
> categories: [
>     "base"
> ]
> annotations: {
>     FreeBSD_version: "1600000"
> }
> #
> 
> other than the vital flag, does this match what you have?


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>