[Bug 268490] [igb] [lagg] [vlan]: Intel i210 performance severely degraded

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268490

--- Comment #20 from Daniel Duerr <duerrd561@gmail.com> ---
(In reply to Kevin Bowling from comment #19)

Sure. I started with an up to date `releng/12.4` branch with no changes. The
`git revert 6486e9dd8d24b0195facd23d8ca82e17e180cffb` command could not apply
cleanly without manual conflict resolution. I think I resolved it properly --
here's the diff between my local version and origin/releng/12.4:

[root@nfs src]# git diff origin/releng/12.4 sys/dev/e1000/if_em.c
diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c
index a9ab2fb21535..0f20449db6ec 100644
--- a/sys/dev/e1000/if_em.c
+++ b/sys/dev/e1000/if_em.c
@@ -1361,7 +1361,7 @@ em_if_init(if_ctx_t ctx)
        em_setup_vlan_hw_support(ctx);

        /* Don't lose promiscuous settings */
-       em_if_set_promisc(ctx, if_getflags(ifp));
+       em_if_set_promisc(ctx, IFF_PROMISC);
        e1000_clear_hw_cntrs_base_generic(&sc->hw);

        /* MSI-X configuration for 82574 */

I then proceeded to build and install a GENERIC kernel from this source. After
rebooting on the new kernel, I re-ran the `iperf` tests and the performance is
still terrible:

[root@nfs dd]# iperf -s
------------------------------------------------------------
Server listening on TCP port 5001
TCP window size: 64.0 KByte (default)
------------------------------------------------------------
[  1] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 50946
[  2] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 27230
[  3] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 53346
recv failed: Connection reset by peer
[ ID] Interval       Transfer     Bandwidth
[  1] 0.00-79.38 sec  60.0 Bytes  6.05 bits/sec
recv failed: Connection reset by peer
[  2] 0.00-79.38 sec  60.0 Bytes  6.05 bits/sec
recv failed: Connection reset by peer
[  3] 0.00-79.38 sec  60.0 Bytes  6.05 bits/sec
[SUM] 0.00-122.08 sec   180 Bytes  11.8 bits/sec

Did I do the revert wrong? Or do we need to look at other changes that were
made in the em driver?

-- 
You are receiving this mail because:
You are the assignee for the bug.