From nobody Thu Feb 16 15:13:37 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PHdkT53Zlz3qYbT for ; Thu, 16 Feb 2023 15:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PHdkT3wM5z3mr8 for ; Thu, 16 Feb 2023 15:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676560417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yF+EMjaTftXfaoM1gHubSreu480H/3JvZghfdtQocXQ=; b=R7lL9FHyzVPXe5Oep4FvBwGzIPNpYDpzym11xq4VT2qk5pS7pVgv7orF/LqPpEi3fKykn5 1RauxGaN0kRt3KMWaj2wMma0FEUaQyYk+ChB05ewH/ra1hd9oGbqHF97MAGBmN81b2JMm0 4+zgV7fPRXAtcItOAFW5OVhfubTeY6+WrXQkzzMd6qVDniE6lN0ub6zvYLQX4B1a6GxcWP 2eZtf3IrK70stvzzBq59Mutl9g6DhXGdR8HMQ5+9c2FIxMsfeCNGdUy1jm0hE9BBM1komF AQS8K46ISv3jc1p0puGs3h5mE8RTHEbjcYpaaaZeC1J2yBHGqeG939q5PpGqYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676560417; a=rsa-sha256; cv=none; b=eByVJaKF36ZOlXcCTPKxMRETMbMWenRpAC4aVrenR6YB2vaWXsgvlTNY3TyTlN8sOQF8PT MI7yEmopgqH+6aKOSzTeTfCFVhKJehRgddQv9g/CkVOOcvdby6FjVugG04ocpVYBNWOvJ9 JUOkD5N6dasiY08DiPUb8eqHL9iQMtXh9OBN1XKOhVlzxzMo0bCtlPaCrnKG38MjA/gaGP Y8q4HOhiFHvjEAtZV5EbK6vrVi3lem1rl1QVYoPB4nD9l4dUUutxkN1mI1R/eWNkpFRlUk Nb/QQX1Un7s9yO/PgGhnSKRiREj9NE1ddTJyUk9MWIR2ZyUtsMoZHpfvrgAvhg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PHdkT329Rz17kT for ; Thu, 16 Feb 2023 15:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31GFDbAS065325 for ; Thu, 16 Feb 2023 15:13:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31GFDbBg065324 for net@FreeBSD.org; Thu, 16 Feb 2023 15:13:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268490] [igb] [lagg] [vlan]: Intel i210 performance severely degraded Date: Thu, 16 Feb 2023 15:13:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.4-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: duerrd561@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268490 --- Comment #20 from Daniel Duerr --- (In reply to Kevin Bowling from comment #19) Sure. I started with an up to date `releng/12.4` branch with no changes. The `git revert 6486e9dd8d24b0195facd23d8ca82e17e180cffb` command could not app= ly cleanly without manual conflict resolution. I think I resolved it properly = -- here's the diff between my local version and origin/releng/12.4: [root@nfs src]# git diff origin/releng/12.4 sys/dev/e1000/if_em.c diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index a9ab2fb21535..0f20449db6ec 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -1361,7 +1361,7 @@ em_if_init(if_ctx_t ctx) em_setup_vlan_hw_support(ctx); /* Don't lose promiscuous settings */ - em_if_set_promisc(ctx, if_getflags(ifp)); + em_if_set_promisc(ctx, IFF_PROMISC); e1000_clear_hw_cntrs_base_generic(&sc->hw); /* MSI-X configuration for 82574 */ I then proceeded to build and install a GENERIC kernel from this source. Af= ter rebooting on the new kernel, I re-ran the `iperf` tests and the performance= is still terrible: [root@nfs dd]# iperf -s ------------------------------------------------------------ Server listening on TCP port 5001 TCP window size: 64.0 KByte (default) ------------------------------------------------------------ [ 1] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 50946 [ 2] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 27230 [ 3] local 172.27.6.135 port 5001 connected with 172.27.6.129 port 53346 recv failed: Connection reset by peer [ ID] Interval Transfer Bandwidth [ 1] 0.00-79.38 sec 60.0 Bytes 6.05 bits/sec recv failed: Connection reset by peer [ 2] 0.00-79.38 sec 60.0 Bytes 6.05 bits/sec recv failed: Connection reset by peer [ 3] 0.00-79.38 sec 60.0 Bytes 6.05 bits/sec [SUM] 0.00-122.08 sec 180 Bytes 11.8 bits/sec Did I do the revert wrong? Or do we need to look at other changes that were made in the em driver? --=20 You are receiving this mail because: You are the assignee for the bug.=