Re: openjdk build failures on "nm"

Ok.

Change didn't work. Did learn a bit more.

The openjdk build totally ignores MAKE_JOBS_UNSAFE and MAKE_JOBS_NUMBER. :-)
See:
https://pkg-status.freebsd.org/beefy16/data/135amd64-default/56c5cbbc8d99/logs/openjdk17-17.0.16+8.1_1.log
checking for number of cores... 28
checking for memory size... 130926 MB
checking for appropriate number of jobs to run in parallel... 28
The configure script detects cores and memory and calculates itself how many jobs it uses.

I now added these lines to the openjdk17/Makefile and tested in my poudriere that this makes the build take these variables into account.
+.if defined(MAKE_JOBS_UNSAFE)
+CONFIGURE_ARGS+=       --with-jobs=1
+.elif defined(MAKE_JOBS_NUMBER)
+CONFIGURE_ARGS+=       --with-jobs=${MAKE_JOBS_NUMBER}
+.endif
Any objections or is everybody happy if I add this?

Regards,
Ronald.


 
Van: Ronald Klop <ronald-lists@klop.ws>
Datum: donderdag, 11 september 2025 11:26
Aan: Harald Eilertsen <haraldei@anduin.net>
CC: java@freebsd.org
Onderwerp: Re: openjdk build failures on "nm"
> 
> I committed the change.
> 
> Looking through https://portsfallout.com/fallout?port=java/openjdk again, I noticed that it does not fail on main, only on 13.5 and 14.2. I don't know if that is a coincidence, a difference in the pkg cluster on main or some difference in clang/llvm or other build tooling.
> 
> But I thought it is worth mentioning.
> 
> Regards,
> Ronald.
> 
>  
> Van: Harald Eilertsen <haraldei@anduin.net>
> Datum: donderdag, 11 september 2025 10:15
> Aan: Ronald Klop <ronald-lists@klop.ws>
> CC: java@freebsd.org
> Onderwerp: Re: openjdk build failures on "nm"
>> 
>> On Thu, Sep 11, 2025 at 09:32:08AM +0200, Ronald Klop wrote:
>> > As it seems hard to debug, what do the java@ maintainers think of this experiment?
>> >
>> > diff --git a/java/openjdk17/Makefile b/java/openjdk17/Makefile
>> > index 5cb25e6aee72..ba7001ff2bd0 100644
>> > --- a/java/openjdk17/Makefile
>> > +++ b/java/openjdk17/Makefile
>> > @@ -38,7 +38,7 @@ GH_PROJECT=   jdk17u
>> >
>> > NO_CCACHE=     yes
>> >
>> > -_MAKE_JOBS=    #
>> > +MAKE_JOBS_UNSAFE=      yes
>> > MAKE_ENV=      LANG="C" \
>> >                LC_ALL="C" \
>> >                CLASSPATH="" \
>> 
>> That's well spotted! I think this is definitely worth trying. I'm no
>> expert on the ports Makefiles myself, but was told to use
>> MAKE_JOBS_UNSAFE instead in the review for openjdk24. Haven't gone
>> through all the ancient version yet, as my focus is mainly on mainline,
>> and these days on openjdk25.
>> 
>> > I can commit this today to openjdk17 and if builds start to succeed to other openjdk* ports.
>> 
>> I'm in favour!
>> 
>> H!
>> 
>> 
>> 
> 
>