Re: Forgotten MFC

On Thu, Apr 17, 2025 at 4:32 PM Dag-Erling Smørgrav <des@freebsd.org> wrote:
>
> Alexander Leidinger <Alexander@Leidinger.net> writes:
> > There is some code which tracks commits and looks for "MFC after:". It
> > emails the developer when the time has passed.
>
> That hasn't worked in years.  I received three MFC reminders in 2023;
> there hasn't been a single one since, and the most recent one before
> that was in 2019.

Check your spam folder.... I got MFC reminders in the last couple of weeks.

Plus there's an online MFC tracker, but also we've grown good tooling in the
tree to find things that haven't been merged, tagged or not.

We really need to go to a system where we can add Notes to commits after
the fact (like we did with svn numbers in the conversion) so that we can tag
commits after the fact for merging (I forgot, or don't think it's
important enough
at the time, only to change my mind later) as well as say 'nope, this
has a problem
don't commit it' as well as gathering groups together to merge as a
unit incrementally
(again, for those that the committer might not have tagged it as
x-mfc-with because
the dependency was unknown at commit time).  The notes are optional, and one
can clone them or not, unless one wants the functionality, so it
doesn't affect the
instructions that we send out. And adding notes doesn't change the hash, though
notes aren't versioned very well (but well enough to reconstruct
accidental or malicious
damage).  And we need to move away from the cherry-pick -x to having an explicit
MFC-From: trailer (and move to real trailers for everything). But
that's a lot and I've
not figured out how to cut the gordian knot to get the ball rolling on it.

Warner