From nobody Fri Apr 18 01:16:00 2025 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zdxfj0ckWz5t6HJ for ; Fri, 18 Apr 2025 01:16:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zdxfj035Wz3L5J for ; Fri, 18 Apr 2025 01:16:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-b0db0b6a677so563722a12.2 for ; Thu, 17 Apr 2025 18:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1744938972; x=1745543772; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kGIXKOP/TqsM9uqeLT9ElPcTde1YzkiXv+oDDbUqQVs=; b=hEn73VtVp8szvXjDKxFkuwSYhjHFDdMCk5jvSGKFZXMW/iA8YqtmQBQBoCZ13ApHZt 2aFzJF8H13rl1pZBjNE9MyvefxCiQR3mioamNAV0xHMUWKqD8E0HxRZLpOcM0Kt70Sa5 U2HfitYAz1W8T3Cr2zpLAzuWKborqKb49eKJe/BIzVHpGtsq1axhgzn5jUANcMfjx3W9 yjMJQ60zOHGl68fyYP9u9NZGjvlnpcfF/vRWe0loht8Ya/3EQFpaXQKpRaEGlPudmdEt DfD6rQRhzXG7HwYB+4gT1pwSLPGnDmrY63xq+NCjegWnMLojd/5N4fvqt5KOVWkXf6T/ tAUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744938972; x=1745543772; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kGIXKOP/TqsM9uqeLT9ElPcTde1YzkiXv+oDDbUqQVs=; b=TB21xoj3pcLurBS6nd1pNTW4b7jL9P63L9iMe3cnWzA0r9A/p+1jvewlTV2zwQglet kebwQOV923rPYwbgGOEPDow5vRy28sfp+xbnWVnDi5cAG34OlW3Zp76vb0Yo8dLwcTmc 2k3Q/md2ClzWImnX1cRNOCyLGzdsJbyzvlyMFKEpO3LZZMFJNuylK6FZZwlOI7Wf7UMJ zNR8hU/tY0RVI9mKn/y2tSG6Hsr1PrEl8eOeaEwAjGP974rUPdAidfH/41V6CQ4psTVz HW0OAkOER67BMg9qvSLE1bpYtZg+noUXrNFLFGsgOVkZZWvEbYqzSwz5xj3nXWCnEw7L gvYg== X-Forwarded-Encrypted: i=1; AJvYcCXR1WWmNa+9MVOgGegPh/5NP5JRFQfP+2rkQg6w5XYJqVKQGYEZ0NNTOv4yj3SBFvk3MSioF6gZ4lT0q6NnRmw=@freebsd.org X-Gm-Message-State: AOJu0YzVc0K5ix/PYbqcjgOfRpQofynE9gu93XbRP7uXOpzEv5yFk0sq qCJNh/rMFJGunJ2LKHw7RwZNjam+Zj6TzuXdkk0xDI6G4WZMHRPNzRwCIaXiAwjyDcl3UyMCqU3 2MCLlpbxs4Sh7I4mLKeo9hgWdxFX6BpRfpiAViKs8XR8kw65d X-Gm-Gg: ASbGnctN/0dJUM9gf6E10wEz5oZQPOS1R8iaUNNCfBNLRbNtx3fUL3gG7yoxcTnLIJT 5bEQLpC9KVTAQiQB4pz+NDDKghl+LQ0KZptcDAgjeA7p+M5KrqsYtsH/f8vfEdsjlgCqZeQi23I w5gy60+Y/BML2aeBHTrGMSnXAkQ8PS/TuQtV3gv25WtTHxxEZGuI4= X-Google-Smtp-Source: AGHT+IFf3CexWE0YzuuGEzVwZxdmBF/t+Ji2RgKoIh7BGK3wAoXSB5qMpv329/nT/h/TZ+YG1sx2uOSC0cNmzRQhKsg= X-Received: by 2002:a17:90b:3a4b:b0:2fe:b774:3ec8 with SMTP id 98e67ed59e1d1-3087bcc7f59mr1195976a91.23.1744938971739; Thu, 17 Apr 2025 18:16:11 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org MIME-Version: 1.0 References: <20250411204934.d574639172d393183ace4749@bk.ru> <20250412040913.9fc4944e0cf6142e086f4bad@dec.sakura.ne.jp> <20250412134658.e41004e25df0044a6f5498e6@bk.ru> <86ecxqbzuq.fsf@ltc.des.dev> In-Reply-To: <86ecxqbzuq.fsf@ltc.des.dev> From: Warner Losh Date: Thu, 17 Apr 2025 19:16:00 -0600 X-Gm-Features: ATxdqUFhGebr9aJbtfNHA9JmbfJxh8Y-jRxErzaJDvppQqpgI0gqnupVVPV7ai4 Message-ID: Subject: Re: Forgotten MFC To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: Alexander Leidinger , Artem Bunichev , Tomoaki AOKI , freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Zdxfj035Wz3L5J X-Spamd-Bar: ---- On Thu, Apr 17, 2025 at 4:32=E2=80=AFPM Dag-Erling Sm=C3=B8rgrav wrote: > > Alexander Leidinger writes: > > There is some code which tracks commits and looks for "MFC after:". It > > emails the developer when the time has passed. > > That hasn't worked in years. I received three MFC reminders in 2023; > there hasn't been a single one since, and the most recent one before > that was in 2019. Check your spam folder.... I got MFC reminders in the last couple of weeks. Plus there's an online MFC tracker, but also we've grown good tooling in th= e tree to find things that haven't been merged, tagged or not. We really need to go to a system where we can add Notes to commits after the fact (like we did with svn numbers in the conversion) so that we can ta= g commits after the fact for merging (I forgot, or don't think it's important enough at the time, only to change my mind later) as well as say 'nope, this has a problem don't commit it' as well as gathering groups together to merge as a unit incrementally (again, for those that the committer might not have tagged it as x-mfc-with because the dependency was unknown at commit time). The notes are optional, and on= e can clone them or not, unless one wants the functionality, so it doesn't affect the instructions that we send out. And adding notes doesn't change the hash, th= ough notes aren't versioned very well (but well enough to reconstruct accidental or malicious damage). And we need to move away from the cherry-pick -x to having an exp= licit MFC-From: trailer (and move to real trailers for everything). But that's a lot and I've not figured out how to cut the gordian knot to get the ball rolling on it. Warner