Re: Backout git revision 4179e6b78297369f [that is also stable/15 and releng/15.0 as 62c3b77d1d10]

On Tue, 11 Nov 2025, Steve Kargl wrote:

> On 11/11/25 12:12, Ed Maste wrote:
>> On Sun, 9 Nov 2025 at 02:01, Steve Kargl <kargls@comcast.net> wrote:
>>> 
>>> It's not a big ask.  Either back out the commit or maybe,
>>> just maybe, someone can commit the patch in PR290432.
>> 
>> For current, reverting the commit is a nonstarter.
>> 
>> In PR290432 I don't see a report that WANT_NATIVE_PCI_GET_SLOT fully
>> fixes the issue, just that it fixes the build. Can you confirm that's
>> sufficient to fix it?
>
> Yes, it fixes the issue.  After the build completes, one
> can install drm-515 on freebsd-current, and life returns
> to normal.
>
> IIUC, bz@ indicated that the patch may be break stable-14.
> I don't use stable branches so cannot verify.  May need to
> use a _FreeBSD_version check, but I have no idea how that
> would look.

I have a todo item now to install myself a pourdriere for all currently supported
branches so I can test and if it does not fail push the fix into ports.
May take a day or two as I have other things on the plate as well.


Your fix wouldn't break stable/14 but if I'll merge wireless that would,
which is one of the reasons stable/14 hasn't seen a lot of the wireless
updates and I think then the solution will be to have a backout patch for
14.3-R and stable/14 up to that point.  Or I'll find I cannot MFC wireless
as it'll just break things and then 14.x is stuck with whatever it has now
for the rest of the branch lifetime (which is still quite long).

We'll see.

/bz

-- 
Bjoern A. Zeeb                                                     r15:7