Re:_rescue_-_usr.bin/id/id.c:149:16:_err or:_use_of_undeclared_identifier_'Aflag'

On November 2, 2025 2:29:48 PM GMT+02:00, David Wolfskill <david@catwhisker.org> wrote:
>On Sun, Nov 02, 2025 at 08:32:59AM +0200, Sulev-Madis Silber wrote:
>> there's no newer current than this
>> 
>> and i get this error
>> 
>> 
>> (cd /root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/rescue/rescue/../../usr.bin/id &&  make MK_PIE=no NO_SHARED=yes -DRESCUE CRUNCH_CFLAGS=-DRESCUE CRUNCH_CFLAGS+=-I/root/files/poudriere/obj/current-armv7-minimal/root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/arm.armv7/lib/libifconfig MK_AUTO_OBJ=yes DIRPRFX=rescue/rescue/id/ depend && make MK_PIE=no NO_SHARED=yes -DRESCUE CRUNCH_CFLAGS=-DRESCUE CRUNCH_CFLAGS+=-I/root/files/poudriere/obj/current-armv7-minimal/root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/arm.armv7/lib/libifconfig MK_AUTO_OBJ=yes DIRPRFX=rescue/rescue/id/ id.o)
>> echo id: /root/files/poudriere/obj/current-armv7-minimal/root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/arm.armv7/tmp/usr/lib/libc.a  >> .depend
>> cc -target armv7-gnueabihf-freebsd16.0 --sysroot=/root/files/poudriere/obj/current-armv7-minimal/root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/arm.armv7/tmp -B/root/files/poudriere/obj/current-armv7-minimal/root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/arm.armv7/tmp/usr/bin  -O2 -pipe -fno-common   -DRESCUE -I/root/files/poudriere/obj/current-armv7-minimal/root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/arm.armv7/lib/libifconfig -DNDEBUG -MD  -MF.depend.id.o -MTid.o -std=gnu17 -Wno-format-zero-length -nobuiltininc -idirafter /usr/lib/clang/19/include -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wnested-externs -Wold-style-definition -Wno-pointer-sign -Wdate-time -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=unused-but-set-parameter -Wno-error=cast-function-type-mismatch  -Qunused-arguments     -c /root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/usr.bin/id/id.c -o id.o
>> /root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/usr.bin/id/id.c:149:16: error: use of undeclared identifier 'Aflag'
>>   149 |         if ((cflag || Aflag || Mflag) && argc > 0)
>>       |                       ^
>> /root/files/poudriere/basefs/jails/current-armv7-minimal/usr/src/usr.bin/id/id.c:152:10: error: use of undeclared identifier 'Aflag'
>>   152 |         combo = Aflag + Gflag + Mflag + Pflag + gflag + pflag + uflag;
>>       |                 ^
>> 2 errors generated.
>> *** [id.o] Error code 1
>> ....
>
>I just performed an in-place source-based update from
>
>FreeBSD 16.0-CURRENT #637 main-n281638-e4f2a3509554: Sat Nov  1 12:58:41 UTC 2025     root@g1-120.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY amd64 1600003 1600003
>
>to
>
>FreeBSD 16.0-CURRENT #638 main-n281643-c3a3af134668: Sun Nov  2 11:55:09 UTC 2025     root@g1-120.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY amd64 1600003 1600003
>
>(on 3 machines; the 4th is presently building packages, but should get
>around to the above later today) without complaint or issue.
>
>In case it's relevant, I'm using "meta" mode on these machines.
>
>Peace,
>david

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290740

i fixed it

problem is that

70b72ede982f3aebe03a2bf7a8245ee6bcde352c

introduces a change which doesn't allow id to compiled if audit is not on

commit says

id: Clean up
No functional change intended.

but in fact it has that breaking change included in it which both coder and reviewer(s) missed

until i came with my minimized src.conf with motherload of without_*'s and it blew up

it's not the first time i catch a bug in current

anyone wanting to build mini current can apply a patch there