Re: Tooling Integration and Developer Experience

From: Warner Losh <imp_at_bsdimp.com>
Date: Mon, 30 Jan 2023 16:58:55 UTC
I think just "sys/dev/dpaa2" is all you need when adding the Herald rule. :)

More generally, no, there's no way that I've found to only match files that
match certain regexp.

Warner

On Mon, Jan 30, 2023 at 9:49 AM Dmitry Salychev <dsl@mcusim.org> wrote:

>
> Warner Losh <imp@bsdimp.com> writes:
>
> > On Mon, Jan 30, 2023 at 7:07 AM Dmitry Salychev <dsl@mcusim.org> wrote:
> >
> >  Hi,
> >
> >  Kurt Jaeger <pi@freebsd.org> writes:
> >
> >  > Hi,
> >  >
> >  >> > On 1/30/23 02:54, Julian H. Stacey wrote:
> >  >> >    The main idea: to prevent information fragmentation and
> improve
> >  >> >    discoverability, cross-referencing abilities, search, etc.
> >  >>
> >  >> With regards to improving discoverability, Phabricator's Owner
> >  >> tool could be a good tactical move: it allow to bind code area to
> >  >> peoples in order to automatically add them to reviews.
> >  >
> >  > If you know phabricator in more detail, is there any kind of tool
> >  > to understand the activity going on ?
> >  >
> >  > In bugs.freebsd.org, there is the dashboard:
> >  >
> >  > https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html
> >  >
> >  > I think we might need something similar to help us understand
> >  > the current state of the phabricator instance and the work
> >  > being done.
> >  >
> >  > Phab allows Dashboards, but no-one had the time to configure some
> >  > queries to provide relevant stats.
> >
> >  I'd prefer to have an automatic note via email from Phabricator if any
> >  file with my copyright was modified/patched/improved in a newly opened
> >  review.
> >
> >  I don't think that people tend to ignore changes to those parts of code
> >  they've written (or touched at least).
> >
> > You can easily create a herald rule to do this. I have one for all of
> src, but others have subsets
> > like the boot loader. And anybody with an account can do that.
> >
> > Warner
>
> Looks really useful, thanks for a hint. Is there any way to test regexp
> matching for files content? Btw, there could be a carefully selected set
> of pre-defined Herald rules added to any new committer's account.
>
> --
> Dmitry Salychev
>