From nobody Mon Jan 30 16:58:55 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P5Dt34NNLz3bxVZ for ; Mon, 30 Jan 2023 16:59:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P5Dt340hCz4GrM for ; Mon, 30 Jan 2023 16:59:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62d.google.com with SMTP id hx15so14109149ejc.11 for ; Mon, 30 Jan 2023 08:59:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YRd5Xr0RvTecNibA13NDeOUAzRWE5rNWiQkd/dkvwCU=; b=04LRJOxjAQLVwugcgHohFKQmzq9Qi+B19Nc+h9mEp+BPLh8sErEy4aR/EB54RnBhaS cwya2xXoIUgt0yrTFty8n1hIOiXFO7UDZchNkX+44UwTCbqAR50Ls/YtbQ8vQ4lewJNz LVrMj0leywwyXVqUqEdOt/P1bCmgkjwjrLsPoiv1inD7srA1ielVhhuJM6P4mnwCRqyZ 85es7OWYnXSj3sCvf8XFJ6fJov0NRuDGPegyFqUBplKf6QephW0oOmteFKWtg87LkUhf yjcUm2d9j4z6OrZrn7lWZq3Qfra1rE8pA1NolZtpkVsk2E+KUWuVXJuzsMBh4L+p4/uH Ch0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YRd5Xr0RvTecNibA13NDeOUAzRWE5rNWiQkd/dkvwCU=; b=nmv15PzARhvVr40MUMbu85iYAzK7cwzn//TQn0yHtnQ3sExRLmH2siUkRh6lHgJU5F dhMemAcWBdk8dxbEMR6NRP/q3IzLCmFvKIo5BviJ2a/5uA3QtRSoP2cNiWY4P/NLYFZ7 2hGdXsHmu7LKxt7LJbezIVQ8C1MwWylzEx8gyDe9CEXckdMywQMbOkhpENGSjpQIe/V8 nGGnYz4G7Guj7e0IcklRG0s+PGt26tDgDbXteWBixRNKitWix27LF/qaHFdn9mGqxgx+ RhrM2MGki3iKfdBCHmz72bziH6wPmTcMkswguA85+1seKrX5eu0rMzE8nR2Q37BaEDu5 +bKQ== X-Gm-Message-State: AFqh2krAJtkM03vXwzSR4A22z2n5zGk4Mh5cW6DItbUk/eMbaUGOLXOE KPHY8MGrWTBvbucfmzzq+UTk+DzLNU40tSJSto7FIA== X-Google-Smtp-Source: AMrXdXuQLtWWcfaorr3O9FUMKiJujGoGwZu7f4dCGTC/9OF0Sjy2m2YHlBgcenXXIQGy2vH5b8Mu5sWx7wp8f69QS0M= X-Received: by 2002:a17:906:2752:b0:86f:f0ce:a227 with SMTP id a18-20020a170906275200b0086ff0cea227mr8263653ejd.160.1675097946411; Mon, 30 Jan 2023 08:59:06 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <202301300254.30U2sm0k061914@dell.no.berklix.net> <97020cad-f913-2985-2093-e4c23bf671e3@antonovs.family> <86357sxsly.fsf@cthulhu.stephaner.labo.int> <86edrcp13z.fsf@peasant.tower.home> <86zga0nf1q.fsf@peasant.tower.home> In-Reply-To: <86zga0nf1q.fsf@peasant.tower.home> From: Warner Losh Date: Mon, 30 Jan 2023 09:58:55 -0700 Message-ID: Subject: Re: Tooling Integration and Developer Experience To: Dmitry Salychev Cc: Kurt Jaeger , Stephane Rochoy , freebsd-current@freebsd.org Content-Type: multipart/alternative; boundary="0000000000000f630c05f37e22b5" X-Rspamd-Queue-Id: 4P5Dt340hCz4GrM X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000000f630c05f37e22b5 Content-Type: text/plain; charset="UTF-8" I think just "sys/dev/dpaa2" is all you need when adding the Herald rule. :) More generally, no, there's no way that I've found to only match files that match certain regexp. Warner On Mon, Jan 30, 2023 at 9:49 AM Dmitry Salychev wrote: > > Warner Losh writes: > > > On Mon, Jan 30, 2023 at 7:07 AM Dmitry Salychev wrote: > > > > Hi, > > > > Kurt Jaeger writes: > > > > > Hi, > > > > > >> > On 1/30/23 02:54, Julian H. Stacey wrote: > > >> > The main idea: to prevent information fragmentation and > improve > > >> > discoverability, cross-referencing abilities, search, etc. > > >> > > >> With regards to improving discoverability, Phabricator's Owner > > >> tool could be a good tactical move: it allow to bind code area to > > >> peoples in order to automatically add them to reviews. > > > > > > If you know phabricator in more detail, is there any kind of tool > > > to understand the activity going on ? > > > > > > In bugs.freebsd.org, there is the dashboard: > > > > > > https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html > > > > > > I think we might need something similar to help us understand > > > the current state of the phabricator instance and the work > > > being done. > > > > > > Phab allows Dashboards, but no-one had the time to configure some > > > queries to provide relevant stats. > > > > I'd prefer to have an automatic note via email from Phabricator if any > > file with my copyright was modified/patched/improved in a newly opened > > review. > > > > I don't think that people tend to ignore changes to those parts of code > > they've written (or touched at least). > > > > You can easily create a herald rule to do this. I have one for all of > src, but others have subsets > > like the boot loader. And anybody with an account can do that. > > > > Warner > > Looks really useful, thanks for a hint. Is there any way to test regexp > matching for files content? Btw, there could be a carefully selected set > of pre-defined Herald rules added to any new committer's account. > > -- > Dmitry Salychev > --0000000000000f630c05f37e22b5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think just "sys/dev/dpaa2" is all you need whe= n adding the Herald rule. :)

More generally, no, there&#= 39;s no way that I've found to only match files that match certain rege= xp.

Warner

On Mon, Jan 30, 2023 at 9:49 AM Dm= itry Salychev <dsl@mcusim.org> = wrote:

Warner Losh <imp@bsd= imp.com> writes:

> On Mon, Jan 30, 2023 at 7:07 AM Dmitry Salychev <dsl@mcusim.org> wrote:
>
>=C2=A0 Hi,
>
>=C2=A0 Kurt Jaeger <pi@freebsd.org> writes:
>
>=C2=A0 > Hi,
>=C2=A0 >
>=C2=A0 >> > On 1/30/23 02:54, Julian H. Stacey wrote:
>=C2=A0 >> >=C2=A0 =C2=A0 The main idea: to prevent information= fragmentation and=C2=A0 =C2=A0 improve
>=C2=A0 >> >=C2=A0 =C2=A0 discoverability, cross-referencing ab= ilities, search, etc.
>=C2=A0 >>
>=C2=A0 >> With regards to improving discoverability, Phabricator&= #39;s Owner
>=C2=A0 >> tool could be a good tactical move: it allow to bind co= de area to
>=C2=A0 >> peoples in order to automatically add them to reviews.<= br> >=C2=A0 >
>=C2=A0 > If you know phabricator in more detail, is there any kind o= f tool
>=C2=A0 > to understand the activity going on ?
>=C2=A0 >
>=C2=A0 > In bugs.freebsd.org, there is the dashboard:
>=C2=A0 >
>=C2=A0 > https://bugs.freebsd.o= rg/bugzilla/page.cgi?id=3Ddashboard.html
>=C2=A0 >
>=C2=A0 > I think we might need something similar to help us understa= nd
>=C2=A0 > the current state of the phabricator instance and the work<= br> >=C2=A0 > being done.
>=C2=A0 >
>=C2=A0 > Phab allows Dashboards, but no-one had the time to configur= e some
>=C2=A0 > queries to provide relevant stats.
>
>=C2=A0 I'd prefer to have an automatic note via email from Phabrica= tor if any
>=C2=A0 file with my copyright was modified/patched/improved in a newly = opened
>=C2=A0 review.
>
>=C2=A0 I don't think that people tend to ignore changes to those pa= rts of code
>=C2=A0 they've written (or touched at least).
>
> You can easily create a herald rule to do this. I have one for all of = src, but others have subsets
> like the boot loader. And anybody with an account can do that.
>
> Warner

Looks really useful, thanks for a hint. Is there any way to test regexp
matching for files content? Btw, there could be a carefully selected set of pre-defined Herald rules added to any new committer's account.

--
Dmitry Salychev
--0000000000000f630c05f37e22b5--