Re: WITHOUT_PF breaks buildworld

On Wed, Dec 22, 2021, 12:37 PM Gary Jennejohn <gljennjohn@gmail.com> wrote:

> On Wed, 22 Dec 2021 10:58:50 -0600
> Warner Losh <imp@bsdimp.com> wrote:
>
> > On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn <gljennjohn@gmail.com>
> wrote:
> >
> > >
> > > This simple patch to /usr/src/include/Makefile fixes it for me:
> > >
> > > --- Makefile.orig       2021-12-22 13:37:02.817745000 +0100
> > > +++ Makefile    2021-12-22 13:37:12.177336000 +0100
> > > @@ -246,9 +246,7 @@
> > >  INCSGROUPS+=   IPFILTER
> > >  .endif
> > >
> > > -.if ${MK_PF} != "no"
> > >  INCSGROUPS+=   PF
> > > -.endif
> > >
> > >  .if ${MK_CDDL} != "no"
> > >  INCSGROUPS+=   NVPAIR
> > >
> > > Since pf.h is used so widely in the tree it's probably the simplest
> fix.
> > >
> >
> > I like this. I'd unconditionally remove the test in preference to adding
> it
> > conditionally.
> >
>
> If I still had my commit bit I'd do it myself :-)
>

I can do it tonight.  I'm on the road today dri ING back from Omaha..

Warner

-- 
> Gary Jennejohn
>