From nobody Wed Dec 22 18:52:15 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A469F190BC59 for ; Wed, 22 Dec 2021 18:52:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JK2WP3x2fz4Rg3 for ; Wed, 22 Dec 2021 18:52:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x930.google.com with SMTP id i6so5833512uae.6 for ; Wed, 22 Dec 2021 10:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D2m19K7ajAKN+5bI5lp7urGRH58gy0qA6FqC8Wnvr5s=; b=5wMCR4Cj+xv+g0DQHv6iwUOZVELpWGT200PUuxv3eZWjJWHuF2x2TLA9jXa9of/mX7 dvSSDeFx+Hfgk6apkNZsqDphGN1swx+/6GowbDFM8wQk9Kbk+Qt4Lrs0rTg2wULMMDsR AEhLUTkqDAZILZizbxmyPhePavrkojcJBo9rT4qIt+iZJh0/5I45LxCXDWWHvvy8HFgw I3Xx/dbq2nmw1afQtt1V4w7tJtUUDjKF/rOCeHjE/kWQpD6ecLaGgSkFt4flEOkUPH+k lHA+4WNBGlXbAXIspdo87bGuRQW5xGRGnKZFskJsQmTfdiQzL0uIGFNP8zy/mqp8XinX QvBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D2m19K7ajAKN+5bI5lp7urGRH58gy0qA6FqC8Wnvr5s=; b=E4Oo+wAznY8gidj7v7KTfPmc6+rAnFpbt3Re70xkZ+nMPW5SZ1/ZhWEAzc8Bq0x1Jc rzHKS8J3/sQyBIFmw6jS8uKkHOHJ8XZ0VoEZxO9MC7arlfFbCi1VxtJCvXP9iY1SHTRw 2aqDVonbd4QPQg/kGRWC1Px8wiOc40PWknx9DsIFFGyhUDtjaapsmRsOsE5TDZ1mAcon nrFzEzo04Vr3du+ObqaqRcBVZ6eaF2MNE/Mi3+kDeonaKLruCLSpX6sdMOhMDQoKSvhz m1+73zYSTiMouOxHD25fcqxzhIfYdaWYQ01Xry2tY73roVElnGIm4D+9hNVJ5GTrUEQ+ QlPQ== X-Gm-Message-State: AOAM533yZwz8yGkWgmnu5ewkOETdE+t8KcliwAx6apPaSAF3Uk5fI2X0 ViIyI/XzH/Y1Qebuzhped35u2PnmCuPBPsehhFj8xsGNWmI= X-Google-Smtp-Source: ABdhPJy7RiVr+GFqy/sAR191KEfSa1mt3iEurpbStiE/dhgHk4vK8JIh06aNG703ETNjiIq24WZRJBz/crrFYHTmDq8= X-Received: by 2002:a05:6102:da:: with SMTP id u26mr1567731vsp.42.1640199147257; Wed, 22 Dec 2021 10:52:27 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <20211219114723.338b235e@ernst.home> <61bf1204.1c69fb81.2c8fc.3280SMTPIN_ADDED_BROKEN@mx.google.com> <20211219122443.1c84093f@ernst.home> <74FC7625-295C-4DEC-BF35-434B5F8D7832@FreeBSD.org> <20211222165154.33ef54fd@ernst.home> <20211222170151.05a4afe3@ernst.home> <20211222193725.19f2f03a@ernst.home> In-Reply-To: <20211222193725.19f2f03a@ernst.home> From: Warner Losh Date: Wed, 22 Dec 2021 12:52:15 -0600 Message-ID: Subject: Re: WITHOUT_PF breaks buildworld To: Gary Jennejohn Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="00000000000088923005d3c09f3e" X-Rspamd-Queue-Id: 4JK2WP3x2fz4Rg3 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --00000000000088923005d3c09f3e Content-Type: text/plain; charset="UTF-8" On Wed, Dec 22, 2021, 12:37 PM Gary Jennejohn wrote: > On Wed, 22 Dec 2021 10:58:50 -0600 > Warner Losh wrote: > > > On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn > wrote: > > > > > > > > This simple patch to /usr/src/include/Makefile fixes it for me: > > > > > > --- Makefile.orig 2021-12-22 13:37:02.817745000 +0100 > > > +++ Makefile 2021-12-22 13:37:12.177336000 +0100 > > > @@ -246,9 +246,7 @@ > > > INCSGROUPS+= IPFILTER > > > .endif > > > > > > -.if ${MK_PF} != "no" > > > INCSGROUPS+= PF > > > -.endif > > > > > > .if ${MK_CDDL} != "no" > > > INCSGROUPS+= NVPAIR > > > > > > Since pf.h is used so widely in the tree it's probably the simplest > fix. > > > > > > > I like this. I'd unconditionally remove the test in preference to adding > it > > conditionally. > > > > If I still had my commit bit I'd do it myself :-) > I can do it tonight. I'm on the road today dri ING back from Omaha.. Warner -- > Gary Jennejohn > --00000000000088923005d3c09f3e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Dec 22, 2021, 12:37 PM Gary Jennejohn <gljennjohn@gmail.com> wrote:
=
On Wed, 22 Dec 2021 10:58:50 -0600
Warner Losh <imp@bsdimp.com> wrote:

> On Wed, Dec 22, 2021, 10:02 AM Gary Jennejohn <gljennjohn@gmail.c= om> wrote:
>
> >
> > This simple patch to /usr/src/include/Makefile fixes it for me: > >
> > --- Makefile.orig=C2=A0 =C2=A0 =C2=A0 =C2=A02021-12-22 13:37:02.8= 17745000 +0100
> > +++ Makefile=C2=A0 =C2=A0 2021-12-22 13:37:12.177336000 +0100
> > @@ -246,9 +246,7 @@
> >=C2=A0 INCSGROUPS+=3D=C2=A0 =C2=A0IPFILTER
> >=C2=A0 .endif
> >
> > -.if ${MK_PF} !=3D "no"
> >=C2=A0 INCSGROUPS+=3D=C2=A0 =C2=A0PF
> > -.endif
> >
> >=C2=A0 .if ${MK_CDDL} !=3D "no"
> >=C2=A0 INCSGROUPS+=3D=C2=A0 =C2=A0NVPAIR
> >
> > Since pf.h is used so widely in the tree it's probably the si= mplest fix.
> >=C2=A0
>
> I like this. I'd unconditionally remove the test in preference to = adding it
> conditionally.
>

If I still had my commit bit I'd do it myself :-)

I can do it tonight.= =C2=A0 I'm on the road today dri ING back from Omaha..

Warner

=
--
Gary Jennejohn
--00000000000088923005d3c09f3e--