[Bug 258271] www/chromium: Makefile warning for grep mempcpy /usr/include/string.h. This warning is redundant and persistent.

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 13 Sep 2021 12:57:50 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258271

--- Comment #13 from Felix Palmen <felix_at_palmen-it.de> ---
(In reply to Tomoaki AOKI from comment #12)
> If swiching to OSVERSION way, and the addition of mempcpy() is planned to be
> MFC'ed to stable/12 and stable/11, this port should be required to updated
> again, while (ugly) grep hack doesn't need it.
I see the point; in fact, if this change already hit stable/13, my OSVERSION
based patch is already wrong :( -- but…

> I wonder which way would be better for this huge port.
I still think it's the better approach cause calling external tools should be
avoided. These things could pile up and kill any make performance. At the very
least, make sure to do these calls only when really required to expand the
variable in question (which is what my patch does).

Of course, just an opinion so far. IMHO, go with the "fixed" grep for now, but
revisit this once OSVERSION bumps refer the change in question.

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Mon Sep 13 2021 - 12:57:50 UTC

Original text of this message