[Bug 289871] bsdinstall should not offer shells that are not installed

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289871

Graham Perrin <grahamperrin@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|FreeBSD-set-minimal: unable |bsdinstall should not offer
                   |to login after bsdconfig    |shells that are not
                   |chsh to csh                 |installed

--- Comment #6 from Graham Perrin <grahamperrin@gmail.com> ---
Thanks, 

(In reply to Lexi Winter from comment #5)

> we will not add csh to minimal.

If the installation is minimal, then either: 

a) bsdinstall should not offer to add users; or 

b) if the operator does choose to add a user, 
   bsdinstall should not offer a choice of shells.

<https://github.com/freebsd/freebsd-src/blob/52eb7e394a7e28e9b08e2096c4a085a384cc1dd0/usr.sbin/adduser/adduser.sh#L99-L114>,
maybe?

----

After using FreeBSD-15.0-ALPHA4-amd64-20250927-d2b670b27f37-280334-dvd1.iso to
perform a minimal installation: 


Script started on Sun Sep 28 08:28:12 2025
root@2g:~ # adduser
Username: hello
Full name: hello world
Uid (Leave empty for default): 
Login group [hello]: 
Login group is hello. Invite hello into other groups? []: operator,video,wheel
Group operator,video,wheel does not exist!
Login group is hello. Invite hello into other groups? []: operator video wheel
Login class [default]: 
Shell (sh csh tcsh nologin) [sh]: tcsh
Home directory [/home/hello]: 
Home directory permissions (Leave empty for default): 
Enable ZFS encryption? (yes/no) [no]: 
Use password-based authentication? [yes]: 
Use an empty password? (yes/no) [no]: 
Use a random password? (yes/no) [no]: 
Enter password: 
Enter password again: 
Lock out the account after creation? [no]: 
Username    : hello
Password    : *****
Full Name   : hello world
Uid         : 1002
ZFS dataset : zroot/home/hello
Class       : 
Groups      : hello operator video wheel
Home        : /home/hello
Home Mode   : 
Shell       : /bin/tcsh
Locked      : no
OK? (yes/no) [yes]: 
adduser: INFO: Successfully created ZFS dataset (zroot/home/hello).
adduser: INFO: Successfully added (hello) to the user database.
Add another user? (yes/no) [no]: 
Goodbye!
root@2g:~ # exit

Script done on Sun Sep 28 08:29:18 2025

-- 
You are receiving this mail because:
You are the assignee for the bug.