[Bug 276709] hms(4): two finger scroll stops half way unless dev.hms.0.drift_thresh=0
Date: Tue, 26 Nov 2024 10:48:51 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276709
--- Comment #4 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=c0a5ee953f41905038aadba7b7d0df2af6612e71
commit c0a5ee953f41905038aadba7b7d0df2af6612e71
Author: Edward Tomasz Napierala <trasz@FreeBSD.org>
AuthorDate: 2024-11-25 15:08:10 +0000
Commit: Edward Tomasz Napierala <trasz@FreeBSD.org>
CommitDate: 2024-11-26 10:28:51 +0000
hms(4): improve scroll with IICHID_SAMPLING
The current quirk is designed to discard duplicated data read from
the chip. Problem is, it also discards real events when they happen
to be identical, which is the case with scroll wheel events;
differently from X/Y they always move by fixed offset. This results
in two-finger scroll that would stop mid-way that could be fixed by
manually setting dev.hms.0.drift_thresh to 0.
To fix that, don't discard duplicates when there's wheel movement.
For users with actual duplicates problem this will result in scroll
suddenly becoming quite inertial, but it will stop moving at any touch,
so shouldn't be terrible.
PR: kern/276709
Reviewed By: wulf
Differential Revision: https://reviews.freebsd.org/D47640
sys/dev/hid/hms.c | 32 ++++++++++++++++++++++++++++++--
1 file changed, 30 insertions(+), 2 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.